While we are here, I predict the following two things will be
obstacles to your patch.

1. We need a test plan. Impala is tested partially via
http://jenkins.impala.io:8080, which does not have any ppc64le worker
machines it can launch tests on. It is possible that some sort of
virtual machine or emulation could allow this to run on the
currently-available x86-64 machines. If not, another plan should
probably be made.

2. If this line means your patch has 168 files, it will face a serious
problem getting reviewed:

> Counting objects: 168, done.

I'm not sure if I'm interpreting that line correctly. In case I am:

The median number of files changed in a patch is 4. This patch would
be in the top 0.5% of all Impala patches, ordered by number of files
changed.

It is very difficult to review large patches. I encourage you to break
this up into small, reviewable chunks.

Reply via email to