FYI I have a patch up against clang-tidy to add this feature: https://reviews.llvm.org/D34654 Hoping it will be reviewed/committed soon.
-Todd On Thu, Jul 13, 2017 at 10:58 AM, Henry Robinson <[email protected]> wrote: > To close this loop - I took the blunt instrument approach and removed the > directory (which is the imported kudu code) from tidying consideration the > same way we do gutil in run_clang_tidy.sh. Nothing else seemed to work as > one might think it should. > > On 12 July 2017 at 17:46, Jim Apple <[email protected]> wrote: > > > The clang-diagnostics are, IIRC, also enabled by the -W flags. You could > > try turning all warnings off via compiler flags. > > > > There is also a tool that auto-fixes clang-tidy warnings, but only some > of > > them, and I never got even that much to work :-/ > > > > On Wed, Jul 12, 2017 at 5:24 PM, Henry Robinson <[email protected]> > wrote: > > > > > That does not, for whatever reason, actually disable > clang-diagnostic-*. > > I > > > don't know why either :/ > > > > > > On 12 July 2017 at 17:15, Jim Apple <[email protected]> wrote: > > > > > > > What about "diagnostic-henry-thinks-will- > > never-fire,-*,-clang-diagnosti > > > > c-*"? > > > > > > > > > > > > > > > > On Wed, Jul 12, 2017 at 5:01 PM, Henry Robinson <[email protected]> > > > wrote: > > > > > > > > > Has anyone found a way to disable all clang-tidy checks for a > > > directory? > > > > > > > > > > I've tried a directory-specific .clang-tidy file with > > > > > > > > > > --- > > > > > Checks: "-*" > > > > > > > > > > but that causes clang-tidy to exit with an error (because I didn't > > > > > configure any checks). So I tried adding one check that I thought > > would > > > > > never fire. But that silently re-enables a bunch of > clang-diagnostic* > > > > > checks that I don't want. > > > > > > > > > > This happens when running: > > > > > > > > > > git diff HEAD~1 | > > > > > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/share/clan > > > > > g/clang-tidy-diff.py" > > > > > -clang-tidy-binary > > > > > "${IMPALA_TOOLCHAIN}/llvm-${IMPALA_LLVM_VERSION}/bin/clang-tidy" > -p > > 1 > > > > > > > > > > per > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action? > > > > pageId=65868536 > > > > > > > > > > Any ideas? Am I running clang-tidy wrong? > > > > > > > > > > > > > > > > > > -- > Henry Robinson > Software Engineer > Cloudera > 415-994-6679 > -- Todd Lipcon Software Engineer, Cloudera
