dockerzhang opened a new issue #689:
URL: https://github.com/apache/incubator-inlong/issues/689
<p>1. TubeBroker implements Runnable interface, I think this is a little
strange. If we have some extra work to do , we can create inner thread for it.
<br/>
2. JVMClusterUtil is useless . If we support start more than one broker in
one JVM, we have to change some params, we can't set different params for
different brokers at the same time. And as we will support docker in the
future, we decide to remove this class.<br/>
3. remove synchronized in start method.<br/>
4. remove below codes in stop method</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent
panelContent">
<pre class="code-java">
<span class="code-keyword">if</span> (<span
class="code-keyword">this</span>.shutdown.get()) {
<span class="code-keyword">return</span>;
}
</pre>
</div></div>
<p>5. remove unused run method.<br/>
6. remove unused waitForServerOnline method.</p>
<i>JIRA link - <a
href="https://issues.apache.org/jira/browse/INLONG-90";>[INLONG-90]</a> created
by technoboy</i>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
