dockerzhang opened a new issue #821:
URL: https://github.com/apache/incubator-inlong/issues/821
<p>If you just want to extract the unboxed primitive values, calling the
static parseXXX(...) method will be more efficient than valueOf(...).</p>
<p>In the Integer.valueOf(String xxx) source code, it also calls the
parseInt(...) method to parse the primitive value.</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent
panelContent">
<pre class="code-java">
<span class="code-comment">//java.lang.<span
class="code-object">Integer</span>
</span>
<span class="code-keyword">public</span> <span
class="code-keyword">static</span> <span class="code-object">Integer</span>
valueOf(<span class="code-object">String</span> s) <span
class="code-keyword">throws</span> NumberFormatException {
<span class="code-keyword">return</span> <span
class="code-object">Integer</span>.valueOf(parseInt(s, 10));
}</pre>
</div></div>
<p>In the following files, I think we can optimize it:</p>
<p><em>(latest master-branch #132 - commit:1aab3c4)</em></p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent
panelContent">
<pre class="code-java">
org/apache/tubemq/corebase/policies/FlowCtrlRuleHandler.java:626
org/apache/tubemq/corebase/policies/FlowCtrlRuleHandler.java:633
org/apache/tubemq/server/broker/BrokerServiceServer.java:1210
org/apache/tubemq/server/broker/msgstore/MessageStore.java:562
org/apache/tubemq/server/broker/msgstore/MessageStore.java:564
org/apache/tubemq/server/broker/msgstore/MessageStore.java:566
org/apache/tubemq/server/broker/msgstore/MessageStore.java:568
org/apache/tubemq/server/common/aaaserver/SimpleCertificateBrokerHandler.java:88
org/apache/tubemq/server/common/fileconfig/AbstractFileConfig.java:104-105
org/apache/tubemq/server/common/fileconfig/AbstractFileConfig.java:127-128
org/apache/tubemq/server/common/fileconfig/AbstractFileConfig.java:151
org/apache/tubemq/server/common/fileconfig/AbstractFileConfig.java:174
org/apache/tubemq/server/common/utils/WebParameterUtils.java:367
org/apache/tubemq/server/common/utils/WebParameterUtils.java:369
org/apache/tubemq/server/common/utils/WebParameterUtils.java:371
org/apache/tubemq/server/common/utils/WebParameterUtils.java:373
org/apache/tubemq/server/master/balance/DefaultLoadBalancer.java:722
org/apache/tubemq/server/master/balance/DefaultLoadBalancer.java:727
org/apache/tubemq/server/master/bdbstore/bdbentitys/BdbBrokerConfEntity.java:264
org/apache/tubemq/server/master/bdbstore/bdbentitys/BdbBrokerConfEntity.java:274
org/apache/tubemq/server/master/bdbstore/bdbentitys/BdbBrokerConfEntity.java:291
org/apache/tubemq/server/master/bdbstore/bdbentitys/BdbBrokerConfEntity.java:308
org/apache/tubemq/server/master/bdbstore/bdbentitys/BdbBrokerConfEntity.java:325
org/apache/tubemq/server/master/bdbstore/bdbentitys/BdbBrokerConfEntity.java:342
org/apache/tubemq/server/master/bdbstore/bdbentitys/BdbGroupFlowCtrlEntity.java:189
org/apache/tubemq/server/master/bdbstore/bdbentitys/BdbTopicConfEntity.java:292
org/apache/tubemq/server/master/bdbstore/bdbentitys/BdbTopicConfEntity.java:302
org/apache/tubemq/server/master/bdbstore/bdbentitys/BdbTopicConfEntity.java:319
org/apache/tubemq/server/master/bdbstore/bdbentitys/BdbTopicConfEntity.java:336
org/apache/tubemq/server/tools/BdbGroupAdmin.java:70
</pre>
</div></div>
<p>I also found an unnecessary 'String.valueOf()' call.</p>
<p><em>org/apache/tubemq/server/broker/web/BrokerAdminServlet.java:284</em></p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent
panelContent">
<pre class="code-java">
inputTopicName = <span
class="code-object">String</span>.valueOf(inputTopicName).trim();
</pre>
</div></div>
<p> </p>
<i>JIRA link - <a
href="https://issues.apache.org/jira/browse/INLONG-222";>[INLONG-222]</a>
created by cku328</i>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
