[GitHub] [incubator-inlong] dockerzhang opened a new issue #1035: [INLONG-446] Small bugs fix that do not affect the main logics

[GitBox]

dockerzhang opened a new issue #1035:
URL: https://github.com/apache/incubator-inlong/issues/1035


   <p>Found some small bugs<br/>
    1. AddressUtils.getIPV4LocalAddress() should first check whether 
localIPAddress has been set, and use it directly under the premise that it has 
been set to reduce unnecessary get operations, locate: <a 
href="https://github.com/apache/incubator-tubemq/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/AddressUtils.java#L146";
 class="external-link" 
rel="nofollow">https://github.com/apache/incubator-tubemq/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corebase/utils/AddressUtils.java#L146</a></p>
   
   <p><span class="image-wrap" style=""><img 
src="https://issues.apache.org/jira/secure/attachment/13016763/13016763_image-2020-12-09-18-53-02-498.png";
 style="border: 0px solid black" /></span></p>
   
   <p>2. The fetchCount parameter in MessageConsumerExample may be negative, so 
the executorService object should not use fetchCount as the initial value, 
locate:<a 
href="https://github.com/apache/incubator-tubemq/blob/master/tubemq-example/src/main/java/org/apache/tubemq/example/MessageConsumerExample.java#L99";
 class="external-link" 
rel="nofollow">https://github.com/apache/incubator-tubemq/blob/master/tubemq-example/src/main/java/org/apache/tubemq/example/MessageConsumerExample.java#L99</a></p>
   
   <p><span class="image-wrap" style=""><img 
src="https://issues.apache.org/jira/secure/attachment/13016762/13016762_image-2020-12-09-18-53-55-711.png";
 style="border: 0px solid black" /></span></p>
   
   <p> </p>
   
   <p>3. Remove the useless parameter WITHOUTDELAY:</p>
   
   <p><span class="image-wrap" style=""><img 
src="https://issues.apache.org/jira/secure/attachment/13016775/13016775_image-2020-12-09-20-04-14-698.png";
 style="border: 0px solid black" /></span></p>
   
   <p> </p>
   <i>JIRA link - <a 
href="https://issues.apache.org/jira/browse/INLONG-446";>[INLONG-446]</a> 
created by gosonzhang</i>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org