coderappee opened a new issue, #7358:
URL: https://github.com/apache/inlong/issues/7358

   ### Description
   
   Found some ungraceful import of util tool classes in subproject of InLong 
Manager, e.g. manager-service
   For example:
   1. 
org.apache.inlong.manager.service.resource.sink.greenplum.GreenplumSqlBuilder 
import the org.apache.commons.compress.utils.Lists util tool class from 
commons-compress
   2. 
org.apache.inlong.manager.service.resource.sink.postgresql.PostgreSQLSqlBuilder 
import the org.apache.commons.compress.utils.Lists util tool class from 
commons-compress
   3. org.apache.inlong.manager.service.source.StreamSourceServiceTest import 
the org.apache.curator.shaded.com.google.common.collect.Maps util tool class 
from curator-client
   
   I the these import util tool classes are not graceful
   1. since the pom of manager-service does not explicitly depend on 
commons-compress/curator-client, manager-service uses these jars throuth the 
thrid party dependencies.
   2. old version of commons-compress.jar does not contain the Lists util tool 
class.
   
   Most Important, manager-service depends on manager-common, and 
manager-common depends on guava.
   Most of the InLong proejct util tools come from guava.
   I think it's more graceful to import Lists/Maps util tool classes from guava.
   
   After full search of the project, I only found the above three classes have 
this problem.
   
   
   
   
   
   ### InLong Component
   
   InLong Manager
   
   ### Are you willing to submit PR?
   
   - [X] Yes, I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to