aloyszhang opened a new issue, #10362:
URL: https://github.com/apache/inlong/issues/10362

   ### Description
   
   In the manager, I found some duplicated interfaces, e.g. `InlongGroupService`
   
   ```java
       /**
        * Save inlong group info.
        *
        * @param groupInfo group request need to save
        * @param operator name of operator
        * @return inlong group id after saving
        */
       String save(@Valid @NotNull(message = "inlong group request cannot be 
null") InlongGroupRequest groupInfo,
               String operator);
   
       /**
        * Save inlong group info.
        *
        * @param groupInfo group request need to save
        * @param opInfo userinfo of operator
        * @return detail of inlong group
        */
       String save(@Valid @NotNull(message = "inlong group request cannot be 
null") InlongGroupRequest groupInfo,
               UserInfo opInfo);
   ```
   The only different is the second parameter, one is `operator` and the other 
is `UserInfo`, and the real usage of `UserInfo` is to get the operator by 
`UserInfo#getName()` .
   So, this two methods have the same logic essentially.
   
   We can simplify the code here by unifying the two methods to one.
   
   
   
   ### InLong Component
   
   InLong Manager
   
   ### Are you willing to submit PR?
   
   - [X] Yes, I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@inlong.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to