[ 
https://issues.apache.org/jira/browse/IOTA-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362882#comment-15362882
 ] 

ASF GitHub Bot commented on IOTA-21:
------------------------------------

Github user barbaragomes commented on the issue:

    https://github.com/apache/incubator-iota/pull/5
  
    @phalodi PR has been tested and will be merged once you, please, submit the 
following modifications:
    
    1. `BuildSettings`: change `organization := "com.libit"` to `organization 
:= "org.apache.iota"`
    2. Remove all reference to the fey project since this folder is not 
actually a SBT project, like for example `lazy val fey = Project(` and 
`aggregate = Seq(Stream, ZMQ,fey)`
    3. `PerformersBuild`: Remove `stream` and `zmq` from `mainClass := Some`
    
    I understand that some of the requested changes were part of the first SBT 
Build.scala but it would be nice if we could have all of them in the same PR 
since we are refactoring it =)
    
    Thanks


> Refactor Built of performer to manage multi module dependency more efficient 
> and scala style plugin for code quality 
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: IOTA-21
>                 URL: https://issues.apache.org/jira/browse/IOTA-21
>             Project: Iota
>          Issue Type: Improvement
>            Reporter: sandeep purohit
>            Assignee: sandeep purohit
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> In this improvement refactoring the code to manage multi module dependencies 
> more efficient way and add scala style plugin for code quality .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to