[
https://issues.apache.org/jira/browse/IOTA-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665498#comment-15665498
]
ASF GitHub Bot commented on IOTA-29:
------------------------------------
Github user barbaragomes commented on the issue:
https://github.com/apache/incubator-iota/pull/24
Hey @shiv4nsh, before we can merge this PR would you mind implementing the
items bellow?
1. File: **fey-core/src/main/scala/org/apache/iota/fey/Ensemble.scala**
```
val performerInfo = performers_metadata.getOrElse(performerID, null)
- if(performerInfo != null){
+ if (Option(performerInfo).isDefined) {
```
Instead of creating an Option after the getOrElse please call
**.get(performerID)**, this way the performerInfo is of type Option. (Make sure
all the other implications are resolved as well)
2. File:
**fey-core/src/main/scala/org/apache/iota/fey/FeyGenericActor.scala**
```
if (Option(scheduler).isDefined)
```
Define global variable scheduler as of type Option and make all of the
other necessary changes.
3. File: **fey-core/src/main/scala/org/apache/iota/fey/Monitor.scala**
```
+ if(Option(reason).isDefined){
```
Define parameter reason as of type Option[Throwable] and make the necessary
changes
4. File: **fey-core/src/main/scala/org/apache/iota/fey/TrieNode.scala**
```
(Option(root).isDefined)
```
Define variable root as of type Option and make the necessary changes
> Remove the scalastyle warnings
> ------------------------------
>
> Key: IOTA-29
> URL: https://issues.apache.org/jira/browse/IOTA-29
> Project: Iota
> Issue Type: Improvement
> Affects Versions: 0.1
> Reporter: Shivansh
> Assignee: Shivansh
> Fix For: 0.1
>
>
> Remove the scalastyle warnings as there are currently more than 50 scalastyle
> warnings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
