Hi,

We have a asf.header file in our project, we use this as asf header in codes. 
Maybe we omit some files to use header like "Copyright © 2019 Apache 
IoTDB(incubating) (dev@iotdb.apache.org)". Are there many files use old header? 
I can help to delete them.


Thanks


Xu Yi


On 1/18/2019 22:17,Christofer Dutz<christofer.d...@c-ware.de> wrote:
Hi all,

as I was setting up things so Jenkins will build the project, I noticed that 
you have some strange plugin in the build that enforces headers quite strictly.
I don’t have any objections to that, however it marked my usual ASF headers as 
invalid because they didn’t have the first line in them.

Currently your header looks like this:

Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org)

Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements.  See the NOTICE file
distributed with this work for additional information
regarding copyright ownership.  The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License.  You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

I would strongly suggest to remove the first line. It’s equivalent can be 
automatically generated by a maven plugin and the way it is, I think it would 
require changing each file in the repo every year. I doubt this is what you 
want to do.

What do you others think? (Especially the other mentors)

Chris

Reply via email to