Hi all, In general I think it's problematic to have headers automatically changed, especially by an automated tool..
Think of such a tool like a device that stamps "This is the property of XYZ" on everything in your house ... now you borrow something from a friend and as soon as you bring it home: *bam* the tool slams it's "This belongs to XYZ" on it .... Imagine how your friend will like that? Sometimes code gets added from outside the project, which is absolutely fine as long as it's under a license, which is compatible with the ASF license. But only as long as the header is left as is. I am not a lawyer, but as far as I understood it, only the authors of a piece of code are allowed to change the headers ... an automated tools doesn't qualify for that. Chris Am 19.01.19, 12:13 schrieb "Xiangdong Huang" <[email protected]>: Hi all, I have modify the header of all files.... 1. Now the header is totally the same with https://www.apache.org/legal/src-headers.html#headers 2. apache-rat-plugin is enabled, and `mvn apache-rat:check` is passed. If anyone wants to create a new java file, I suggest you modify your IDE template to generate the header. Notice that the license-maven-plugin (com.mycila) which is added by Yi Xu is still enable. So, you can remove all the headers by running `mvn license:remove` and then add asf header on each file by `mvn license:format`. You need to do this if you reformat source codes to follow Google Java Style (each line has 100 characters, but each line in current header has less than 100 characters). I commit the changes to another branch `fix_license`. Please approve the PR if there is no problem. Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Justin Mclean <[email protected]> 于2019年1月19日周六 上午3:49写道： > Hi, > > I think you can solve that by just adding “.git" to RAT exclusions. [1] > > Thanks, > Justin > > 1. http://creadur.apache.org/rat/apache-rat/ > >
