[GitHub] liuruiyiyang commented on a change in pull request #5: [IOTDB-4] Force WAL in thread periodically

[GitBox]

liuruiyiyang commented on a change in pull request #5: [IOTDB-4] Force WAL in 
thread periodically
URL: https://github.com/apache/incubator-iotdb/pull/5#discussion_r249317051
 
 

 ##########
 File path: 
iotdb/src/main/java/org/apache/iotdb/db/writelog/manager/MultiFileLogNodeManager.java
 ##########
 @@ -123,15 +152,17 @@ public void recover() throws RecoverException {
 
   @Override
   public void close() {
-    if (syncThread == null || !syncThread.isAlive()) {
+    if (syncThread == null || !syncThread.isAlive() || forceThread == null || 
!forceThread
+        .isAlive()) {
 
 Review comment:
   The comparison report is uploaded to JIRA see 
https://issues.apache.org/jira/browse/IOTDB-4 :
   <img width="416" alt="image" 
src="https://user-images.githubusercontent.com/20263106/51451213-32101180-1d6f-11e9-9051-0f0758d7d26f.png";>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services