jixuan1989 commented on a change in pull request #25: Fix sonar
URL: https://github.com/apache/incubator-iotdb/pull/25#discussion_r250497122
##########
File path:
iotdb/src/main/java/org/apache/iotdb/db/conf/directories/strategy/MaxDiskUsableSpaceFirstStrategy.java
##########
@@ -26,7 +26,7 @@
public class MaxDiskUsableSpaceFirstStrategy extends DirectoryStrategy {
// disk space is measured by MB
- private final long dataSizeShift = 1024 * 1024;
+ private static final double DATA_SIZE_SHIFT = 1024D * 1024;
Review comment:
A little strange, why we use MB? (for User view, MB is ok, but in the
program, why not use Byte?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
