Beyyes commented on a change in pull request #9: [IOTDB-5]Embedding
modifications in querying
URL: https://github.com/apache/incubator-iotdb/pull/9#discussion_r250498370
##########
File path:
tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/page/PageReader.java
##########
@@ -109,25 +111,48 @@ private BatchData getAllPageData() throws IOException {
while (timeDecoder.hasNext(timeBuffer)) {
long timestamp = timeDecoder.readLong(timeBuffer);
- pageData.putTime(timestamp);
switch (dataType) {
case BOOLEAN:
- pageData.putBoolean(valueDecoder.readBoolean(valueBuffer));
+ boolean aBoolean = valueDecoder.readBoolean(valueBuffer);
Review comment:
I think we should take these examination type code (boolean, int32, int64,
float, double, etc) into single methods.
Maybe we can do it after the `fix_sonar` pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
