jt2594838 commented on a change in pull request #9: [IOTDB-5]Embedding
modifications in querying
URL: https://github.com/apache/incubator-iotdb/pull/9#discussion_r250596192
##########
File path:
tsfile/src/main/java/org/apache/iotdb/tsfile/read/reader/page/PageReader.java
##########
@@ -109,25 +111,48 @@ private BatchData getAllPageData() throws IOException {
while (timeDecoder.hasNext(timeBuffer)) {
long timestamp = timeDecoder.readLong(timeBuffer);
- pageData.putTime(timestamp);
switch (dataType) {
case BOOLEAN:
- pageData.putBoolean(valueDecoder.readBoolean(valueBuffer));
+ boolean aBoolean = valueDecoder.readBoolean(valueBuffer);
Review comment:
Yeah，I've seen that PR and I will leave this to later merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
