+1 I think this way is better Xiangdong Huang <[email protected]> 于2019年1月25日周五 下午9:11写道：
> Hi all, > > I find another project has the similar problem, and finally they send all > code-reviews to the reviews@ (see [1]). > > I think that it also fits us. As for the dev@, we can discuss about the > issues about Infrastructures (e.g., how to use CI, how to keep code > quality), new features, bugs, performance problems etc. These contents are > more valuable. > > If someone wants to keep tracking with code-reviews or freshman, he can > subscribe the reviews@ mail list. > > For experienced programmers, they can focus on the contents on dev@ > > If all of you agree with it, I will try to open a ticket on JIRA INFRA. > > Reference: > [1] > > https://issues.apache.org/jira/browse/INFRA-12404?jql=text%20~%20%22github%20review%22%20AND%20%20project%20%20%3D%20Infrastructure > > Best, > ----------------------------------- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 > > > 江天 <[email protected]> 于2019年1月25日周五 上午10:34写道： > > > I like the idea of being highly transparent, but we hope to know some > > tricks of doing this. Do we have to paste the code in the mails or just > > tell someone what problem which line in which file has? Both of these > seem > > tiring. > > > > > 在 2019年1月25日，上午1:08，Justin Mclean <[email protected]> 写道： > > > > > > Hi, > > > > > >> No matter what you guys decide to do, I would strongly suggest to take > > discussions here to the list and not do discussions in the Github > > code-review tool. > > > > > > A very big +1 to this, discussion works best for the whole community if > > it is on the list. > > > > > > Thanks, > > > Justin > > > > > > >
