jt2594838 commented on a change in pull request #31: Fix sonar
URL: https://github.com/apache/incubator-iotdb/pull/31#discussion_r251180757
##########
File path:
iotdb/src/main/java/org/apache/iotdb/db/query/executor/EngineExecutorWithoutTimeGenerator.java
##########
@@ -110,25 +127,43 @@ public QueryDataSet executeWithoutFilter()
QueryDataSource queryDataSource =
QueryDataSourceManager.getQueryDataSource(jobId, path);
// add data type
- dataTypes.add(MManager.getInstance().getSeriesType(path.getFullPath()));
+ try {
+
dataTypes.add(MManager.getInstance().getSeriesType(path.getFullPath()));
+ } catch (PathErrorException e) {
+ throw new FileNodeManagerException(e);
+ }
PriorityMergeReader priorityReader = new PriorityMergeReader();
// sequence insert data
- SequenceDataReader tsFilesReader = new
SequenceDataReader(queryDataSource.getSeqDataSource(),
- null);
- priorityReader.addReaderWithPriority(tsFilesReader, 1);
+ SequenceDataReader tsFilesReader = null;
+ try {
+ tsFilesReader = new
SequenceDataReader(queryDataSource.getSeqDataSource(),
+ null);
+ priorityReader.addReaderWithPriority(tsFilesReader, 1);
+ } catch (IOException e) {
+ throw new FileNodeManagerException(e);
+ }
// unseq insert data
- PriorityMergeReader unSeqMergeReader = SeriesReaderFactory.getInstance()
-
.createUnSeqMergeReader(queryDataSource.getOverflowSeriesDataSource(), null);
- priorityReader.addReaderWithPriority(unSeqMergeReader, 2);
+ PriorityMergeReader unSeqMergeReader = null;
+ try {
+ unSeqMergeReader = SeriesReaderFactory.getInstance()
+
.createUnSeqMergeReader(queryDataSource.getOverflowSeriesDataSource(), null);
+ priorityReader.addReaderWithPriority(unSeqMergeReader, 2);
+ } catch (IOException e) {
+ throw new FileNodeManagerException(e);
+ }
readersOfSelectedSeries.add(priorityReader);
}
- return new
EngineDataSetWithoutTimeGenerator(queryExpression.getSelectedSeries(),
dataTypes,
- readersOfSelectedSeries);
+ try {
+ return new
EngineDataSetWithoutTimeGenerator(queryExpression.getSelectedSeries(),
dataTypes,
Review comment:
Yeah, FileNodeManagerException is a high-layer exception. If possible, it
should not be the direct exception to make problems more trackable or
classifiable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
