jt2594838 commented on a change in pull request #34: fix sonar
URL: https://github.com/apache/incubator-iotdb/pull/34#discussion_r251219987
##########
File path: jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBQueryResultSet.java
##########
@@ -52,16 +48,19 @@
import org.apache.iotdb.service.rpc.thrift.TSIService;
import org.apache.iotdb.service.rpc.thrift.TSOperationHandle;
import org.apache.iotdb.service.rpc.thrift.TSQueryDataSet;
-import org.apache.iotdb.service.rpc.thrift.TS_SessionHandle;
+import org.apache.iotdb.tsfile.compress.UnCompressor.SnappyUnCompressor;
import org.apache.iotdb.tsfile.read.common.Field;
import org.apache.iotdb.tsfile.read.common.RowRecord;
import org.apache.thrift.TException;
+import org.slf4j.LoggerFactory;
public class IoTDBQueryResultSet implements ResultSet {
+ private static final org.slf4j.Logger LOGGER =
LoggerFactory.getLogger(SnappyUnCompressor.class);
+ private static final String methodNotSupportedMessage = "Method not
supported";
private final String TIMESTAMP_STR = "Time";
- private final String LIMIT_STR = "LIMIT";
- private final String OFFSET_STR = "OFFSET";
+ private static final String limitStr = "LIMIT";
+ private static final String offsetStr = "OFFSET";
Review comment:
I think static final fields are required to be in uppercase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
