Hi, For a PR, if all checks have passed (now, only Travis-CI check automatically, and we can trigger Jenkins Pipeline manually), and there is no one +1 by any members (who has the write permission of the repository), or there is at least one code-review comment left on Github, I say it as under code-review process...
Anyone can review codes and leave comments. Any reviews will be sent to reviews@ mail list now. For a PR, if there is no person reviews it several days, I think the author can send email on this mail list to ask for reviewing it. As a initial committer, at least I will focus on the PRs. When there is at least +1 for the PR and no more comments in one or two days, anyone who has the write permission can merge the PR into master. Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Justin Mclean <[email protected]> 于2019年1月28日周一 下午1:07写道： > Hi, > > > - 34 PR are submitted on Github, 24 of them are closed; 10 of them are > in code-review process. > > What is this code-review process and how do contributors made aware of it? > Who are the people who review the code? > > Thanks, > Justin
