Hi, Now I know there are many distribution version of OpenJDK, such as OpenJDK built by Oracle, AdoptOpenJDK, AdoptOpenJDK-OpenJ9, ZuzuOpenJDK, etc..
I tried a lot of them and find that their output are familiar. I attached them in this email. Then, I think PR #41 can solve JIRA issue #18 well. PR: https://github.com/apache/incubator-iotdb/pull/41 References: Oracle JDK: docker run --rm sgrio/java-oracle:jdk_11 java -fullversion OUTPUT: java full version "11.0.1+13-LTS" docker run --rm sgrio/java-oracle:jdk_8 java -fullversion OUTPUT: java full version "1.8.0_192-b12" Oracle-OpenJDK: docker run --rm openjdk:11.0.2-jdk-oraclelinux7 java -fullversion OUTPUT: openjdk full version "11.0.2+9" docker run --rm openjdk:8u181-jdk-stretch java -fullversion OUTPUT: openjdk full version "1.8.0_181-8u181-b13-2~deb9u1-b13" AdoptOpenJDK: docker run --rm adoptopenjdk/openjdk11 java -fullversion OUTPUT: openjdk full version "11.0.2+9" docker run --rm adoptopenjdk/openjdk8 java -fullversion OUTPUT: openjdk full version "1.8.0_202-b08" AdoptOpenJDK-OpenJ9: docker run --rm adoptopenjdk/openjdk11-openj9 java -fullversion OUTPUT: openjdk full version "11.0.2+9" docker run --rm adoptopenjdk/openjdk8-openj9 java -fullversion OUTPUT: openjdk full version "1.8.0_202-b08" ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Xiangdong Huang <[email protected]> 于2019年2月2日周六 上午2:03写道： > Hi Andreas, > > Welcome to IoTDB community. Would you kindly to review the PR #39? ( > https://github.com/apache/incubator-iotdb/pull/39) > > Besides, as Yi Xu said, > > For jdk11 , the major version is in the first place, but for jdk8 is in > the second place. So when i get {major_version}.{minor_version}.xx, i will > check whether major_version is 1. if major_version equals to 1, i will use > minor_version. It works on jdk8. Otherwise, for jdk11, major_version equals > to 11 and i will use this value. > > If you run `java -version`, you get a version like `{A}.{B}.{C}`. For jdk > 1.6, 1.7, and 1.8, A=1, and B = 6, 7 or 8; That's why: > IF "%MAJOR_VERSION%" == "1" ( > set JAVA_VERSION=%MINOR_VERSION% > (%MINOR_VERSION% is {B} in my case) > > Best, > ----------------------------------- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 > > > 徐毅 <[email protected]> 于2019年2月1日周五 下午3:57写道： > >> Hi >> >> >> I have created an issue at https://issues.apache.org/jira/browse/IOTDB-18 >> . >> However, I cannot find your openjdk version from Official website at >> http://jdk.java.net/11/. I downloaded OpenJDK11 from website and run >> `java -version`: >> >> >> $ java -version >> openjdk version "11.0.2" 2019-01-15 >> OpenJDK Runtime Environment 18.9 (build 11.0.2+9) >> OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode) >> >> >> It seems openjdk also use `.` to split version not '+', I wonder where >> does this "11+28" come from? Could you provide more info about your OpenJDK >> version? >> >> >> Thanks >> Xu Yi >> >> >> On 2/1/2019 13:59，Willem Jiang<[email protected]> wrote： >> Please create a JIRA to trace this kind of issue. >> >> Willem Jiang >> >> Twitter: willemjiang >> Weibo: 姜宁willem >> >> On Fri, Feb 1, 2019 at 1:42 PM 徐毅 <[email protected]> wrote: >> >> Hi >> >> >> Thanks for your feedback and welcome to our community. >> There is a little difference between jdk8 and jdk11. >> >> >> If you use jdk8 and run `java -version`, you will see >> -------------------------------- >> $ java -version >> java version "1.8.0_181" >> Java(TM) SE Runtime Environment (build 1.8.0_181-b13) >> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode) >> -------------------------------- >> >> >> If you use jdk11 and run `java -version`, you will see >> -------------------------------- >> $ java -version >> java version "11.0.1" 2018-10-16 LTS >> Java(TM) SE Runtime Environment 18.9 (build 11.0.1+13-LTS) >> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.1+13-LTS, mixed mode) >> -------------------------------- >> >> >> For jdk11 , the major version is in the first place, but for jdk8 is in >> the second place. So when i get {major_version}.{minor_version}.xx, i will >> check whether major_version is 1. if major_version equals to 1, i will use >> minor_version. It works on jdk8. Otherwise, for jdk11, major_version equals >> to 11 and i will use this value. >> >> >> Sorry about that I did not take OpenJDK into consideration, OpenJDK uses >> `+` not `.` to split versions, I will find out how to make our script >> compatible with both OracleJDK and OpenJDK soon. >> >> >> Thanks >> Xu Yi >> On 2/1/2019 07:33，Andreas Oswald<[email protected]> wrote： >> Hi, there, >> >> I got the hint to IOTDB from Chris Dutz of codencentric in Germany the >> head of Apache PCL4X (incubating) >> >> I just have privat interest in time series databases. In my former job i >> have worked intensly with a commercial database called infoplus.21 of the >> american company aspentech. Being curious, if one could have got similar >> service with an open source solution, I discussed that with Chris telling >> him, that I had tried InfluxDB and he then told me about your project. >> >> Being brave I started with building from source and ran in some small >> issues when starting the server but now fail to connect the client to the >> server. >> >> I´ve built the sources available from >> https://github.com/apache/incubator-iotdb.git on Windows 10 with Maven >> 3.5.4 and OpenJDK 11+28 >> >> C:\>javac -fullversion >> javac full version "11+28" >> >> The version detection in start-server.bat can´t handle that fullversion >> yet. So for testing I hardcoded >> >> IF "%MAJOR_VERSION%" == "11+28" ( >> set JAVA_VERSION=11 >> REM set JAVA_VERSION=%MINOR_VERSION% >> ) else ( >> set JAVA_VERSION=%MAJOR_VERSION% >> ) >> >> That´s just a hack that brought me to a running server. I could try to >> find a way to detect that in a more flexible way, e.g. checking the first >> to characters and if they form a "11" one can continue as Java 11. Actually >> I have not understood, what the construct >> >> IF "%MAJOR_VERSION%" == "1" ( >> set JAVA_VERSION=%MINOR_VERSION% >> >> should have done. >> >> OK, anyhow, I would like to work on your project and I´d be happy if you >> let me take part and give me access to the mailing list. >> >> Kind regards from Germany >> >> Andreas >> >> >> >> [ >> https://ipmcdn.avast.com/images/icons/icon-envelope-tick-green-avg-v1.png >> ]< >> http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> >> Virenfrei. www.avg.com< >> http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail >> > >> >
