Hi, I created a PR to resolve the problems in the license file that Chris mentioned.
https://github.com/apache/incubator-iotdb/pull/94 1. The LICANSE file contains invalid paths ... I have updated the paths to current sql parser in IoTDB that we used from Hive. I also added the license in Apache Hive to the class header with a notice "Based on *.java from Apache Hive", just as Spark does in https://github.com/apache/spark/blob/master/common/network-common/src/main/java/org/apache/spark/network/util/LimitedInputStream.java where Spark uses the LimitedInputStream from Google Guava. 2. Why is there two LICENSE files? This is quite unusual. The License-binary is merge with License, and there will be only one license file. 3. The binary version references libraries that seem to be referenced by the build: joda-time:joda-time org.apache.maven.wagon:wagon-provider-api org.apache.maven:maven-artifact org.apache.maven:maven-artifact-manager org.apache.maven:maven-model org.apache.maven:maven-plugin-api org.apache.maven:maven-profile org.apache.maven:maven-project org.apache.maven:Maven-repository-metadata org.apache.thrift:Libthrift (should be lower-case libthrift) org.codehaus.plexus:plexus-compiler-api org.codehaus.plexus:plexus-container-default org.codehaus.plexus:plexus-utils org.antlr:antlr org.antlr:ST4 org.antlr:antlr3-maven-plugin These are some dependencies seem to be used by the Maven build and not the built software. This usually isn't mentioned in LICENSE files. I have removed these references in the license file. 4. If org.hamcrest:hamcrest-core is mentioned, so should org.hamcrest:hamcrest-library This is added. Thanks. -- Jialin Qiao School of Software, Tsinghua University 乔嘉林 清华大学 软件学院 > -----原始邮件----- > 发件人: "徐毅" <[email protected]> > 发送时间: 2019-03-12 15:27:18 (星期二) > 收件人: "[email protected]" <[email protected]> > 抄送: > 主题: Re: Do we have a plan to release the first normal version of IoTDB this > month? > > Hi, > > > As you mentioned "The maven-wrapper should be updated to the latest version", > but I did not find anything related to maven wrapper version? > > > Thanks > XuYi > On 3/11/2019 02:31，Christofer Dutz<[email protected]> wrote： > Hi all, > > So I just did a first "mvn clan install -P apache-release" as a test for what > a maven release would produce. > > - Unfortunately I got two test-failures: > IoTDBDeletionIT.test > IoTDBDeletionIT.testMerge > > After disabling those two tests the build passed. > > Then I had a look at the build results. I did notice that the pom doesn't > have an asc (signature), but the sha512 look ok. > > - The LICANSE file contains invalid paths ... > ql/src/java/org/apache/hadoop/hive/ql/ > These don't exist, but seem to have to be changed to: > iotdb/src/java/org/apache/hadoop/hive/ql/ > However these files don't seem to exist at all: > iotdb /src/java/org/apache/hadoop/hive/ql/parse/ASTErrorNode.java > iotdb /src/java/org/apache/hadoop/hive/ql/parse/ASTNodeOrigin.java > iotdb /src/java/org/apache/hadoop/hive/ql/parse/ASTNode.java > > - Why is there two LICENSE files? This is quite unusual. > > - The binary version references libraries that seem to be referenced by the > build: > joda-time:joda-time > org.apache.maven.wagon:wagon-provider-api > org.apache.maven:maven-artifact > org.apache.maven:maven-artifact-manager > org.apache.maven:maven-model > org.apache.maven:maven-plugin-api > org.apache.maven:maven-profile > org.apache.maven:maven-project > org.apache.maven:Maven-repository-metadata > org.apache.thrift:Libthrift (should be lower-case libthrift) > org.codehaus.plexus:plexus-compiler-api > org.codehaus.plexus:plexus-container-default > org.codehaus.plexus:plexus-utils > org.antlr:antlr > org.antlr:ST4 > org.antlr:antlr3-maven-plugin > > Guess usually these are dependencies seem to be used by the Maven build and > not the built software. This usually isn't mentioned in LICENSE files. > > - If org.hamcrest:hamcrest-core is mentioned, so should > org.hamcrest:hamcrest-library > > - Then sometimes multiple different versions of one library are used, which > is not desirable. > > - Why are there two versions of NOTICE files (Haven't checked the content as > it was quite excessive) > > - There doesn't seem to be a RELEASE_NOTES file > > - The maven-wrapper should be updated to the latest version as that version > invalidly contained an Apache header which suggests it's an Apache Software. > This has been brought up in the incubator list and will probably be mentioned > in the future. > Please just update the source files with the latest versions of the > maven-wrapper library. > > So ... now I'll got back to my skiing holidays. Just thought I'd report that > ... not sure if these findings are release-breakers, however it might be a > good idea to address and/or discuss them soon. > > Chris > > > Am 10.03.19, 10:42 schrieb "Christofer Dutz" <[email protected]>: > > In other projects, we usually have release notes also in develop. Here we > have a section for the next planned version right at the top (but with an > "unreleased" appended to the version) and add stuff as it comes in. For a > release the "unreleased" is removed and merged to master, then a new entry > for the next version is added. > > Chris > > Outlook für Android<https://aka.ms/ghei36> herunterladen > > ________________________________ > From: 吴晟 Sheng Wu <[email protected]> > Sent: Sunday, March 10, 2019 4:53:00 AM > To: dev; dev > Subject: Re: Do we have a plan to release the first normal version of IoTDB > this month? > > Hi. > > > Release note should be kept in master or further codes, I think. Users may be > interesting in the changes of old versions, in order to choose right version. > And, make sense to create a new branch to do release, and versiob update. You > could make the version to 0.9.0-snapshot, after the release branch created. > > > > Sheng Wu > Apache SkyWalking, ShardingSphere, Zipkin > > From Wu Sheng 's phone. > > > ------------------ Original ------------------ > From: Xiangdong Huang <[email protected]> > Date: Sun,Mar 10,2019 11:48 AM > To: dev <[email protected]> > Subject: Re: Do we have a plan to release the first normal version of IoTDB > this month? > > > > Hi, > > Do we put this release note into the master branch, or create a new branch > called branch-0.8.0 and put this note into that branch? > (In the pom file of the master branch, the version is still 0.8.0-SNAPSHOT) > > Best, > > ----------------------------------- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 > > > Julian Feinauer <[email protected]> 于2019年3月10日周日 上午4:07写道： > > Hi all, > > I just prepared the initial version of the RELEASE_NOTES as PR in [1]. > I just integrated all closed Jira issues. > Now we should try to add all further (mentionable) improvements. > Personally, I think this is not to crucial as this is the first apache > release, so the question "what changed" or what changed incompatible is not > that crucial as for further releases. > > Best > Julian > > https://github.com/apache/incubator-iotdb/pull/91 > > Am 09.03.19, 11:48 schrieb "Justin Mclean" <[email protected]>: > > Hi, > > In brief, there are four steps: (1) setting Maven configuration; (2) > creating the release branch and prepare the codebase; (3) mvn > release and > deploy and so on; (4) vote. > > You also need to check the LICENSE, NOTICE and DISCLAIMER files in the > release and we can help you with that. > > Thanks, > Justin > > > >
