Hi, Now "do not squash commits" is dominant...
If so, I think we'd better to avoid commit incomplete codes (e.g., I need to change the developing environment from my laptop to my company's PC, so I have to commit current changes and leave a commit log like "temporary commit"...) or squash these commits before you submit a PR. Best. ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Justin Mclean <[email protected]> 于2019年7月11日周四 下午7:34写道： > Hi, > > I also dislike squash commits, you can learn a lot more from more fine > gained commits, you can also do a lot of very use analysis on commits, for > instance see teh book “Your code as a Crime Scene” which include analysis > of version control history to see were bugs are likely to be. But then I’m > not an active committer here so that’s just a general opinion. Is there a > specific reason why hey might be useful to this project? > > Thanks, > Justin
