Hey, logically the PR iss mall but many changed files : )
The only thing I would take to consider is whether we really do want those names for folders. In other projects you usually make the short name for the folder and longer for the artifact, this means folders would be like For example the "server" module would be in the folder "iotdb/server" but with artifactId "iotdb-server". I like those shorter folder names when navigating with the cmd. So I suggest to rename iotdb to "server" but artifactId to "iotdb-server". What do others think? Julian PS.: Oh and I saw that Travis fails.. so does that imply any build-breaking adjustments that we need to do? Am 22.07.19, 14:03 schrieb "Xiangdong Huang" <[email protected]>: Hi, It is a big change because at least 2/3 files are renamed... Best. ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Jialin Qiao <[email protected]> 于2019年7月22日周一 下午7:43写道： > Hi all, > > IoTDB project has the following modules: tsfile, service-rpc, jdbc, iotdb, > grafana, service-rpc, iotdb-cli, example and spark, in which "iotdb" and > "spark" look strange. > > Therefore, I rename iotdb to iotdb-server and spark to spark-tsfile by > "git mv" for retaining the commit history and submit a PR ( > https://github.com/apache/incubator-iotdb/pull/287) to rel/0.8. > > I believe this makes the modules clearer... What do you think? > > Best, > -- > Jialin Qiao > School of Software, Tsinghua University > > 乔嘉林 > 清华大学 软件学院 >
