Hi Jialin,
excellent work!
I'll have a look at the PR today.
From my side this looks excellent and should work.
I know that Chris is on holiday (so we cant ask him).
Perhaps Justin has an opinion on the current state?
From my perspective we have everything together to start the first release
candidate.
So I'll try to spin one up and send an email with further information : )
Best
Julian
Am 23.07.19, 15:33 schrieb "Jialin Qiao" <qj...@mails.tsinghua.edu.cn>:
Hi,
I create a new module called build for generating the tar.gz file using
maven-assembly-plugin. The PR is [1].
After executing "mvn clean package", a "build-0.8.0-release.tar.gz" will
generated under build/target. Is this file ok?
I haven't found how to change the file name to
"iotdb-0.8.0-release.tar.gz", may be renaming the build module to iotdb... Or
is it necessary to change the name?
Besides, After building the tar.gz file, I think copying "sbin, conf, tools
and lib" folders to the target folder may be needless, so I remove this
function in this PR.
[1] https://github.com/apache/incubator-iotdb/pull/295
Best,
--
Jialin Qiao
School of Software, Tsinghua University
乔嘉林
清华大学 软件学院
> -----原始邮件-----
> 发件人: "Julian Feinauer" <j.feina...@pragmaticminds.de>
> 发送时间: 2019-07-23 16:45:37 (星期二)
> 收件人: "dev@iotdb.apache.org" <dev@iotdb.apache.org>
> 抄送:
> 主题: Re: Very frequent commits to rel/0.8
>
> Thank you!
>
> Am 23.07.19, 10:06 schrieb "Jialin Qiao" <qj...@mails.tsinghua.edu.cn>:
>
> Hi Julian,
>
> I like this idea :) It's really troublesome to delete them one by
one....
>
> I submitted a PR[1] to rel/0.8 to do so.
>
> [1] https://github.com/apache/incubator-iotdb/pull/293
>
> Best,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
> > -----原始邮件-----
> > 发件人: "Julian Feinauer" <j.feina...@pragmaticminds.de>
> > 发送时间: 2019-07-23 15:43:07 (星期二)
> > 收件人: "dev@iotdb.apache.org" <dev@iotdb.apache.org>
> > 抄送:
> > 主题: Re: Very frequent commits to rel/0.8
> >
> > Hi Jialin,
> >
> > great, thanks for the summary.
> > As these are artifacts it would be best to copy them to "target/" I
think.
> > Is this okay for you?
> >
> > Julian
> >
> > Am 23.07.19, 09:41 schrieb "Jialin Qiao"
<qj...@mails.tsinghua.edu.cn>:
> >
> > Hi,
> >
> > All known bugs and absent documents are supplemented in
rel/0.8, and the modules haven been renamed. Now we can package the tar.gz
file.
> >
> > Currently, when execute mvn package, the "sbin, conf, lib,
tools" folders in iotdb-server and "sbin, lib, tools" folders in iotdb-client
will be copied to the "conf, sbin, lib, tools" in the root dir. (This is done
by maven-antrun-plugin, and I'm not sure whether copying them to the root dir
is needed.)
> >
> > I'm not familiar with the package, it would be great if Chris
could offer some help :)
> >
> > Best,
> > --
> > Jialin Qiao
> > School of Software, Tsinghua University
> >
> > 乔嘉林
> > 清华大学 软件学院
> >
> > > -----原始邮件-----
> > > 发件人: "Julian Feinauer" <j.feina...@pragmaticminds.de>
> > > 发送时间: 2019-07-22 21:24:12 (星期一)
> > > 收件人: "dev@iotdb.apache.org" <dev@iotdb.apache.org>
> > > 抄送:
> > > 主题: Re: Very frequent commits to rel/0.8
> > >
> > > Hey,
> > >
> > > we should extend the package phase to finally combining all
of those inside one tar.gz file or something which is then moved to target/ as
artefact.
> > >
> > > Regarding the Voting Process:
> > > First, a vote is held on this list.
> > > If the RC passes this vote (I will send some details on what
one should do to cast a Vote, but you can always refer to [1,2]) then a second
vote will be held on gene...@incubator.apache.org which is, formally speaking,
the "real" vote.
> > > If this vote also passes then we move our artefacts to the
released repos and they are "online".
> > >
> > > Finally, we have to finish download links on the homepage and
then we can send out an announce email which goes over all official channels fo
the ASF and push maven artefacts to maven central.
> > >
> > > Then its done : )
> > >
> > > Julian
> > >
> > >
> > > [1] https://www.apache.org/foundation/voting.html
> > > [2] https://www.apache.org/legal/release-policy.html
> > >
> > > Am 22.07.19, 15:08 schrieb "Xiangdong Huang"
<saint...@gmail.com>:
> > >
> > > Hi,
> > >
> > > > PS.: But after that is done I would start the first
release candidate and
> > > we can move to the next phase which is Checking the RC
and Voting : )
> > >
> > > Where it occurs, on this mailing list or
gene...@incubator.apache.org?
> > >
> > > Best,
> > > -----------------------------------
> > > Xiangdong Huang
> > > School of Software, Tsinghua University
> > >
> > > 黄向东
> > > 清华大学 软件学院
> > >
> > >
> > > Julian Feinauer <j.feina...@pragmaticminds.de>
于2019年7月22日周一 下午9:01写道：
> > >
> > > > Hey,
> > > >
> > > > before finally preparing the first RC the only thing
thats missing from my
> > > > side is the packaging oft he binaries.
> > > > As Chris already said, he would offer some help on the
maven assembly
> > > > plugin.
> > > >
> > > > Background is that it’s a "delicate" topic in the ASF
to provide bundled
> > > > artefacts alongside sources (we do not do "binary
releases").
> > > > So at least one wants an automated and reproducibale
way to ensure that
> > > > everyone gets the same binary artefacts and ideally one
can check those (if
> > > > only valid things are inside and such).
> > > >
> > > > But if someone else wants to do the assembly stuff,
feel free : )
> > > > I'm personally lacking skills and experience with that
kind of stuff, so I
> > > > have to rely on other volunteers : )
> > > >
> > > > Julian
> > > >
> > > > PS.: But after that is done I would start the first
release candidate and
> > > > we can move to the next phase which is Checking the RC
and Voting : )
> > > >
> > > > Am 22.07.19, 14:43 schrieb "Xiangdong Huang"
<saint...@gmail.com>:
> > > >
> > > > Hi,
> > > >
> > > > Both PR #282 and #274 are merged.
> > > >
> > > > What is the next? Wait for #287 (rename source
folder)?
> > > >
> > > > Best,
> > > > -----------------------------------
> > > > Xiangdong Huang
> > > > School of Software, Tsinghua University
> > > >
> > > > 黄向东
> > > > 清华大学 软件学院
> > > >
> > > >
> > > > Xiangdong Huang <saint...@gmail.com> 于2019年7月22日周一
下午4:33写道：
> > > >
> > > > > Hi,
> > > > >
> > > > > +1 for DO NOT push more new features into
rel/0.8.
> > > > >
> > > > > Best,
> > > > > -----------------------------------
> > > > > Xiangdong Huang
> > > > > School of Software, Tsinghua University
> > > > >
> > > > > 黄向东
> > > > > 清华大学 软件学院
> > > > >
> > > > >
> > > > > Julian Feinauer <j.feina...@pragmaticminds.de>
于2019年7月22日周一
> > > > 下午4:24写道：
> > > > >
> > > > >> Hi Xiangdong and Jialin,
> > > > >>
> > > > >> I saw both of your work and agree with both!
> > > > >> So this was no general criticism but rather a
sensibilization as I
> > > > also
> > > > >> saw some features that went into.
> > > > >>
> > > > >> As this release is important for learning I
simply took the freedom
> > > > to
> > > > >> put that out explicitly again : )
> > > > >>
> > > > >> Julian
> > > > >>
> > > > >> Am 22.07.19, 10:09 schrieb "Xiangdong Huang"
<saint...@gmail.com>:
> > > > >>
> > > > >> Hi,
> > > > >>
> > > > >> I cherry-picked a modification for fixing
Travis-CI from the
> > > > master to
> > > > >> rel/0.8 just now, otherwise the branch will
fail on Travis...
> > > > >>
> > > > >> Best,
> > > > >> -----------------------------------
> > > > >> Xiangdong Huang
> > > > >> School of Software, Tsinghua University
> > > > >>
> > > > >> 黄向东
> > > > >> 清华大学 软件学院
> > > > >>
> > > > >>
> > > > >> Jialin Qiao <qj...@mails.tsinghua.edu.cn>
于2019年7月22日周一
> > > > 下午3:56写道：
> > > > >>
> > > > >> > Hi Julian,
> > > > >> >
> > > > >> > Thanks for the introduction.
> > > > >> >
> > > > >> > Most of the commits are from PRs that
supplement documents of
> > > > >> version
> > > > >> > 0.8.0. However, these PRs went to master.
> > > > >> >
> > > > >> > From now on, I will change the target of
document-related PRs
> > > > to
> > > > >> rel/
> > > > >> > 0.8.0.
> > > > >> >
> > > > >> > Besides, there are two PRs that should be
merged to rel/
> > > > 0.8.0.
> > > > >> >
> > > > >> > 1. about generating release folder:
> > > > >> >
https://github.com/apache/incubator-iotdb/pull/282
> > > > >> > 2. about TsFile documents:
> > > > >> >
https://github.com/apache/incubator-iotdb/pull/274
> > > > >> >
> > > > >> > Best,
> > > > >> > --
> > > > >> > Jialin Qiao
> > > > >> > School of Software, Tsinghua University
> > > > >> >
> > > > >> > 乔嘉林
> > > > >> > 清华大学 软件学院
> > > > >> >
> > > > >> > > -----原始邮件-----
> > > > >> > > 发件人: "Julian Feinauer"
<j.feina...@pragmaticminds.de>
> > > > >> > > 发送时间: 2019-07-22 15:01:14 (星期一)
> > > > >> > > 收件人: "dev@iotdb.apache.org"
<dev@iotdb.apache.org>
> > > > >> > > 抄送:
> > > > >> > > 主题: Very frequent commits to rel/0.8
> > > > >> > >
> > > > >> > > Hi al,
> > > > >> > >
> > > > >> > > I just checked the git logs and
observerd that there are
> > > > very
> > > > >> frequent
> > > > >> > commits to the branch “rel/0.8”, which
should not be the case.
> > > > >> > > So I’ll try to briefly summarize the
release process or how
> > > > the
> > > > >> > branching model works.
> > > > >> > >
> > > > >> > > The branch rel/0.8 is solely for the
preparation for the
> > > > release.
> > > > >> So NO
> > > > >> > new feature is allowed to come in.
> > > > >> > > All we do in this branch is to clean up
things, fix
> > > > possible bugs
> > > > >> (in
> > > > >> > preparation for the release), finish
release documents or
> > > > artifacts
> > > > >> and
> > > > >> > those things.
> > > > >> > >
> > > > >> > > Everything else goes to master.
> > > > >> > >
> > > > >> > > So there usually is only one direction,
only cherry-picks
> > > > from
> > > > >> rel/0.8
> > > > >> > to master are allowed the other direction
NOT.
> > > > >> > > There are very few circumstances where
one wants to cherry
> > > > pick
> > > > >> from
> > > > >> > master to a rel branch.
> > > > >> > >
> > > > >> > > So please try to focus on the master
branch with
> > > > development.
> > > > >> > > Perhaps it also helps to notify me on
PRs that should go to
> > > > >> rel/0.8.
> > > > >> > >
> > > > >> > > If there are questions please feel free
to ask : )
> > > > >> > >
> > > > >> > > Julian
> > > > >> >
> > > > >>
> > > > >>
> > > > >>
> > > >
> > > >
> > > >
> > >
> > >
> >
> >
>
>
