Hi Justin, PR 300 [1] has been updated according to the comments.
> - Missing incubating in name of artefact > - Name seem wrong "IoTDB Root”? I think it is not very good to add "incubating" on the artifactId of the root pom.xml. Otherwise we have to change it if the project is graduated.. By the way, I checked the artifactId of Hadoop and Spark's pom.xml files, one is called Hadoop-main while the other is called Spark-parent (PLC4x also use plc4x-parent). Therefore, I change the artifactId as "iotdb-parent". Besides, I change the name field as "Apache IoTDB (incubating) Project Parent POM" > - Jars in the source release > - It not immediately obvious of there is any 3rd party code in the source which make license and notice a lot simpler I think there should not be any jars in the source release... Besides, we just modify several source files from Apache Hive (for parsing SQL), so, I think the license (for source code) can be simple... (Now there is no script to get a source-release.tar.gz file, but I think if we download source codes from github, all files except .git can form the source-release.tar.gz file...) > - Docker file seems to using master? I have fixed it in another PR #305 [2]. - Wrong header on this file? /.mvn/wrapper/MavenWrapperDownloader.java It seems the header is correct... (A apache header for java file.) [1] https://github.com/apache/incubator-iotdb/pull/300 [2] https://github.com/apache/incubator-iotdb/pull/305 Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Justin Mclean <[email protected]> 于2019年7月25日周四 下午2:46写道： > Hi, > > > Or, we provide a RC1 (which we do not expect to be the final release) > but have then the community and the mentors check everything. > > I can check it tomorrow (my time). But a quick quick shows a couple of > issues: > - Missing incubating in name of artefact > - Jars in the source release > - Name seem wrong "IoTDB Root”? > - Docker file seems to using master? > - Wrong header on this file? /.mvn/wrapper/MavenWrapperDownloader.java > - It not immediately obvious of there is any 3rd party code in the source > which make license and notice a lot simpler > > Also being a first release, as long as there’s not significant issues, i’s > likely to pass an IPMC vote. > > Thanks, > Justin
