Hi all,

Someone (xiangdong I think) renamed the artifactId of the "root" to 
"incubating-iotdb-parent" to have the incubating in artefact name.
As Chris just send over a patch to include that via assembly plugin I suggest 
to change this back to "iotdb-parent" which is in accordance with what many 
other projects do.

I submitted a PR (with many help from Chris!) which does some other necessary 
final fixed and hope that everybody agrees: 
https://github.com/apache/incubator-iotdb/pull/310

Content is:
Removed "build" module and moved this to parent pom.
Renamed parent pom without incubating.
Added incubating artefact names in assembly plugin.
Added SHA512 for all artefacts.

As soon as the PR is merged I will finally check and prepare an RC this 
weekend, I think.

Best
Julian

Am 26.07.19, 10:45 schrieb "Christofer Dutz" <[email protected]>:

    HI all,
    
    I sent Julian a patch with my changes. Got a lot to do today so I have to 
keep it simple.
    
    Chris
    
    
    Am 26.07.19, 10:05 schrieb "Jialin Qiao" <[email protected]>:
    
        Hi Chris,
        
        Glad to see you back! Our PR [1] separates the license with 
license-binary, updates the artifact in pom and adds "incubating" as the prefix 
of the artefact name. You can check and work in this PR.
        
        [1] https://github.com/apache/incubator-iotdb/pull/300
        
        Best,
        --
        Jialin Qiao
        School of Software, Tsinghua University
        
        乔嘉林
        清华大学 软件学院
        
        > -----原始邮件-----
        > 发件人: "Xiangdong Huang" <[email protected]>
        > 发送时间: 2019-07-26 15:47:29 (星期五)
        > 收件人: [email protected]
        > 抄送: 
        > 主题: Re: Next steps for release 0.8.0-rc1
        > 
        > Hi Chris,
        > 
        > I think It could not be better if there is a PR. The PR makes it 
easier to
        > let us know how to do the same thing in the future..
        > 
        > Best
        > 
        > Christofer Dutz <[email protected]>于2019年7月26日 周五下午3:39写道:
        > 
        > > Hi Justin,
        > >
        > > As I see it, it was producing a source-release without the 
"incubating" in
        > > it ... I just whipped up a patch for that and one that also 
generated the
        > > required sha512 hashes.
        > > Can I just commit that to the release branch, or do we have to do 
the full
        > > PR procedure?
        > >
        > > Chris
        > >
        > >
        > > Am 26.07.19, 09:16 schrieb "Justin Mclean" 
<[email protected]>:
        > >
        > >     Hi,
        > >
        > >     > I am sure I can help with all the issues you are having. 
Could you
        > > please make a list that I can work off?
        > >
        > >     I think everything been sort, but you could take a look at the 
product
        > > artefact to see if you think it has been.
        > >
        > >     Thanks,
        > >     Justin
        > >
        > > --
        > -----------------------------------
        > Xiangdong Huang
        > School of Software, Tsinghua University
        > 
        >  黄向东
        > 清华大学 软件学院
        
    
    

Reply via email to