Hi,

Thanks for this helpful suggestion! I'll try it by implementing TsFileFactory 
and SystemFileFactory.
(They are factories to create files according to different File System, so I 
think the name doesn't need to be "...FileFSFactory"?)




BR,

------------------
Zesong Sun
School of Software, Tsinghua University

??????
???????? ????????


 




------------------ ???????? ------------------
??????: "Xiangdong Huang"<[email protected]>;
????????: 2019??9??9??(??????) ????0:03
??????: "dev"<[email protected]>;

????: Re: Enable to choose storage in local file system or HDFS



Hi,

> do we need the FileFactory for all Files?

A  solution is having two FileSystemUtil classes (or FileFactory),
TsFileFSFactory and the rest.

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

 ??????
???????? ????????


Zesong Sun <[email protected]> ??2019??9??8?????? ????5:24??????

> Hi,
>
>
> I had intended to implement this requirement in the first way, but now I
> think the second and third are better for much less modification of current
> codes... Though the first way may support more than HDFS storage, it may
> still take a lot more time to modify codes in TsFile module based on
> current work.
>
>
>
>
> BR,
> ------------------
> Zesong Sun
> School of Software, Tsinghua University
>
> ??????
> ???????? ????????
>
>
>
>
>
>
>
> ------------------ ???????? ------------------
> ??????: "Jialin Qiao"<[email protected]>;
> ????????: 2019??9??8??(??????) ????2:08
> ??????: "dev"<[email protected]>;
>
> ????: Enable to choose storage in local file system or HDFS
>
>
>
> Hi,
>
> This issue is to let user directly uses spark to read data in IoTDB for
> analyzing.
>
> This function can be done in many ways in IoTDB:
>
> (1) Storing all TsFiles (data files) and other files (system files, WALs)
> on HDFS, then use spark-tsfile to read TsFiles on HDFS.
> (2) Storing only TsFiles on HDFS, and other files on local file system,
> then use spark-tsfile to read TsFiles on HDFS.
> (3) Storing all files on local file system and let user use
> spark-iotdb-connector to read data from IoTDB, regardless where TsFiles
> store.
>
> Personally, I prefer the second and the third. If we use the second way,
> do we need the FileFactory for all Files?
>
> Best,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> ??????
> ???????? ????????
>
> > -----????????-----
> > ??????: "Zesong Sun (Jira)" <[email protected]>
> > ????????: 2019-08-29 19:34:00 (??????)
> > ??????: [email protected]
> > ????:
> > ????: [jira] [Created] (IOTDB-187) Enable to choose storage in local file
> system or HDFS
> >
> > Zesong Sun created IOTDB-187:
> > --------------------------------
> >
> >              Summary: Enable to choose storage in local file system or
> HDFS
> >                  Key: IOTDB-187
> >                  URL: https://issues.apache.org/jira/browse/IOTDB-187
> >              Project: Apache IoTDB
> >           Issue Type: Improvement
> >             Reporter: Zesong Sun
> >
> >
> > Enable to choose storage in local file system or HDFS
> > "is_hdfs_storage=false" by default
> >
> >
> >
> > --
> > This message was sent by Atlassian Jira
> > (v8.3.2#803003)

Reply via email to