Hi Yuan Tian,

Thanks! A minor suggestion: I notice that your PR only adds one file but with 
36 commits, which contains the hadoop-connector's commits.

Maybe it is because that you checkout this branch from the hadoop-connector, 
not the current master. You can try to pull master and then checkout a new 
branch from master next time.

Thanks,
--
Jialin Qiao
School of Software, Tsinghua University

乔嘉林
清华大学 软件学院

> -----原始邮件-----
> 发件人: "Yuan Tian" <[email protected]>
> 发送时间: 2019-09-28 21:55:56 (星期六)
> 收件人: [email protected]
> 抄送: 
> 主题: Re: (IOTDB-246) No docs for Hadoop-Connector in IoTDB websites.
> 
> Hi,
> 
> I have added the Chinese version for Hadoop-connector docs. The PR link is 
> https://github.com/apache/incubator-iotdb/pull/438 
> <https://github.com/apache/incubator-iotdb/pull/438>.
> 
> Best,
> --------------
> Yuan Tian
> School of Software, Tsinghua University
> 
> 田原
> 清华大学 软件学院
> 
> 
> > 在 2019年9月28日,下午5:15,Jialin Qiao <[email protected]> 写道:
> > 
> > Hi Yuan Tian,
> > 
> > Thanks for your contribution. I have reviewed your PR and approved it.
> > 
> > If you have more time, you can add the Chinese doc :)
> > 
> > Best,
> > --
> > Jialin Qiao
> > School of Software, Tsinghua University
> > 
> > 乔嘉林
> > 清华大学 软件学院
> > 
> >> -----原始邮件-----
> >> 发件人: "Yuan Tian" <[email protected]>
> >> 发送时间: 2019-09-28 16:56:37 (星期六)
> >> 收件人: [email protected]
> >> 抄送: 
> >> 主题: Re: (IOTDB-246) No docs for Hadoop-Connector in IoTDB websites.
> >> 
> >> Hi,
> >> 
> >> I have added the docs for Hadoop-connector in our IoDTB website. The pr 
> >> link is https://github.com/apache/incubator-iotdb/pull/437 
> >> <https://github.com/apache/incubator-iotdb/pull/437>.
> >> 
> >> Best,
> >> --------------
> >> Yuan Tian
> >> School of Software, Tsinghua University
> >> 
> >> 田原
> >> 清华大学 软件学院
> >> 
> >> 
> >>> 在 2019年9月28日,下午4:42,Yuan Tian <[email protected]> 写道:
> >>> 
> >>> Hi,
> >>> 
> >>> I’m working on this issue.
> >>> 
> >>> 
> >>> 
> >>> Best,
> >>> --------------
> >>> Yuan Tian
> >>> School of Software, Tsinghua University
> >>> 
> >>> 田原
> >>> 清华大学 软件学院
> >>> 
> >>> 
> >>>> 在 2019年9月28日,下午4:41,Yuan Tian (Jira) <[email protected]> 写道:
> >>>> 
> >>>> Yuan Tian created IOTDB-246:
> >>>> -------------------------------
> >>>> 
> >>>>           Summary: No docs for Hadoop-Connector in IoTDB websites.
> >>>>               Key: IOTDB-246
> >>>>               URL: https://issues.apache.org/jira/browse/IOTDB-246
> >>>>           Project: Apache IoTDB
> >>>>        Issue Type: Improvement
> >>>>          Reporter: Yuan Tian
> >>>> 
> >>>> 
> >>>> There are no docs for Hadoop-Connector in IoTDB websites. Users may not 
> >>>> know how to use the function.
> >>>> 
> >>>> 
> >>>> 
> >>>> --
> >>>> This message was sent by Atlassian Jira
> >>>> (v8.3.4#803005)
> >> 
> 

Reply via email to