Hi,

I was referring to this file:
plc4j/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/util/VersionUtil.java

It references data in the META-INF/MANIFEST-MF file which is created by the jar 
plugin automatically.

Chris


Am 29.09.19, 14:41 schrieb "Xiangdong Huang" <[email protected]>:

    Hi,
    
    > Regarding the version reported... I think the build should ensure this
    being set automatically.   In plc4x in the Kafka integration module we have
    an example.
    
    As for the pom file of hadoop module in IoTDB, it is commented in this
    version. That is why maven release plugin did not modify it in this
    version. The problem will be solved in 0.9, I think.
    
    As for the version problem that Jialin addressed, these version info is
    written in some Java files. Is that possible to modify them automatically?
    I checked the source code of plc4x with kafka (
    plc4j-hello-connectivity-kafka.pom), and did not find the helpful maven
    plugin..
    
    (If let me solve it, I will create a properties file to record the correct
    version, and then reading the version in Java file.. It still needs
    modifying the properties file manually.)
    
    > @Xiangdong you really should go to one of the Key-Signing-Events and have
    your key signed by other Apaches)
    
    I missed that.. @Willem Jiang <[email protected]>, can you help me to
    sign my key? I remember that the key signing should be face to face...
    
    Best,
    -----------------------------------
    Xiangdong Huang
    School of Software, Tsinghua University
    
     黄向东
    清华大学 软件学院
    
    
    Christofer Dutz <[email protected]> 于2019年9月29日周日 下午7:31写道:
    
    > If you really want to do a new rc, then you have to drop the old repo.
    >
    > But I did find a few things, but I also stated them being minor.
    >
    > Regarding the version reported... I think the build should ensure this
    > being set automatically. I wouldn't rely on manual editing. In plc4x in 
the
    > Kafka integration module we have an example.
    >
    > Chris
    >
    > Holen Sie sich Outlook für Android<https://aka.ms/ghei36>
    >
    > ________________________________
    > From: Xiangdong Huang <[email protected]>
    > Sent: Sunday, September 29, 2019 1:10:11 PM
    > To: [email protected] <[email protected]>
    > Subject: Re: Release of 0.8.1
    >
    > Hi,
    >
    > > then I guess we should simply add this to the release documentation
    >
    > I am writing a "how to release" in Chinese... which will mention this
    > problem.
    >
    > Now as Chris and Jialin pointed out some issues, I need to release RC2.
    >
    > My new question is, what should I do on repository.apache.org? Click
    > "drop"
    > button to drop the last item (orgapacheiotdb-1004?)
    > (And, if the vote is passed, do I need to click "Release" button, right?)
    >
    > In document [1], only "clean up the files from dist.apache.org" is
    > mentioned.
    >
    > [1]
    >
    > 
https://plc4x.apache.org/developers/release.html#_toc_cleaning_up_older_release_versions1
    >
    > Best,
    >
    >
    >
    >
    > -----------------------------------
    > Xiangdong Huang
    > School of Software, Tsinghua University
    >
    >  黄向东
    > 清华大学 软件学院
    >
    >
    > Christofer Dutz <[email protected]> 于2019年9月28日周六 下午9:04写道:
    >
    > > Ah ok ... then I guess we should simply add this to the release
    > > documentation ;-)
    > >
    > > Chris
    > >
    > > Am 28.09.19, 00:32 schrieb "Justin Mclean" <[email protected]>:
    > >
    > >     Hi,
    > >
    > >     > And looking at the page, it says "Pre-release" on that page for 
the
    > > given RC …
    > >
    > >     Yep because I changed it to say that :-)
    > >
    > >     Thanks,
    > >     Justin
    > >
    > >
    >
    

Reply via email to