Hi all,

I have just proposed a pull request [1] to fix the release tool and it works on 
my computer now.


This tool was adapted from PLC4X for IoTDB thanks to Julian. 
This tool can help us go through the first step of validating a staged release 
[2]. 
That is, it can download staged artifacts and check their signature and hashes.


To use this tool, run the following command:
```
bash download_staged_release.sh 0.8.1 1
```
`0.8.1` is the version number. `1` is the rc number.




[1] https://github.com/apache/incubator-iotdb/pull/441
[2] 
https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release


Sincerely,
Lei Rui
On 9/29/2019 20:54,Lei Rui<[email protected]> wrote:


Hi all,


Since we are having the next release on the go, I try to use the release tool 
[1] by courtesy of Julian.


I encounter an error "Error: Not a X.Y.Z version number "0.8.0" when I execute 
"bash download_staged_release.sh 0.8.0 2".
I check the code and find the following two functions in common.sh seem to 
return the wrong results:
```
function checkVerNum() {  #  $1: X.Y.Z  returns true/false (0/1)
  if [ `echo $1 | grep -o -E '^\d+\.\d+\.\d+$'` ]; then
    return 0
  else
    return 1
  fi
}


function checkRcNum() {  # $1: rc-num   returns true/false (0/1)
  if [ `echo $1 | grep -o -E '^\d+$'` ] && [ $1 != 0 ]; then
    return 0
  else
    return 1
  fi
}
```
I flip the results and "bash download_staged_release.sh 0.8.0 2" can run 
successfully.


Sincerely,
Lei Rui






[1] https://github.com/apache/incubator-iotdb/tree/tooling-for-release/tools

Reply via email to