+1 for not host the css file in the git repo, as we barely change it. Willem Jiang
Twitter: willemjiang Weibo: 姜宁willem On Mon, Oct 14, 2019 at 2:30 PM Christofer Dutz <[email protected]> wrote: > > So in general we use the: > - maven-dependency-plugin:unpack: for unpacking the content of things > available via normal maven dependencies (A lot of web resources are available > as web-archives) > - download-maven-plugin:wget: for downloading and unpacking content of > archives that have to be downloaded from non-maven places. > > Chris > > > Am 14.10.19, 08:27 schrieb "Christofer Dutz" <[email protected]>: > > Hi, > > as I just mentioned in the PR. I would instead suggest to have maven > fetch the bootstrap package and to copy the parts you need. > > Have a look at the segment of the PLC4X master pom following the comment: > "SITE GENERATION PLUGINS" > https://github.com/apache/plc4x/blob/develop/pom.xml > > Chris > > Am 14.10.19, 07:31 schrieb "Xiangdong Huang" <[email protected]>: > > Hi, > > I notice that in a PR[1], there is a file called bootstrap.min.css. > > I think the file is just absolutely downloaded from bootstrap > projects... > So, for the files like this, do we need apache rat? or just exclude > it? > > [1] > > https://github.com/apache/incubator-iotdb/pull/339/files#diff-fa225ce3dbeba6bc95a5809a17e120a0 > Best, > ----------------------------------- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 > > > >
