Hi,
Lei Rui gives a very detailed check for the release. I summarize them as
follows to notify me to fix them... But, if there is no -1, how about
approve this release....
> - LICENSE: There is a place of duplication:
> ```
> The following class is modified from Maven Wrapper, which is under
Apache License 2.0:
> .mvn/wrapper/MavenWrapperDownloader.java
> ------------
> The following class is modified from Maven Wrapper
> ./.mvn/wrapper/MavenWrapperDownloader.java
> ```
Will fix it in the next release.
> - NOTICE: "Copyright 2019 and onwards" is not incorrect, as Justin has
pointed out.
> - NOTICE-binary: "Copyright 2019 and onwards"
I forgot to fix it and the following issues addressed by Justin. Will fix
them in the next release:
"- NOTICE-binary has "Copyright 2008-2018 The Apache Software Foundation”
this should be 2018-2019.
- NOTICE contains "Copyright 2019 and onwards” this is not correct as
copyright has an expire date. Please replace with "Copyright 2019”
- NOTICE contains "Copyright 2008-2019” for Apache Hive. are these years
correct?."
> c. UNPACK the binary artefact and check the contents of LICENSE-binary
and NOTICE-binary
> - LICENSE-binary: I checked the licenses/ directory and I wonder
what software the license "Eclipse Public License version 2.0 (EPL-2.0)"
corresponds to.
Ok.... can be removed if so..
> And I found the following png marked as "B":
> B
/home/rl/test/downloaded-iotdb-0.8.1rc3/0.8.1/rc3/apache-iotdb-0.8.1-incubating/grafana/img/add_data_source.png
> B
/home/rl/test/downloaded-iotdb-0.8.1rc3/0.8.1/rc3/apache-iotdb-0.8.1-incubating/grafana/img/edit_data_source.png
> B
/home/rl/test/downloaded-iotdb-0.8.1rc3/0.8.1/rc3/apache-iotdb-0.8.1-incubating/grafana/img/add_graph.png
> Is that normal?
I think it is ok because these 3 pictures are made by us (so no copyright
problem I think). They are used for the readme.md file. Maybe we can upload
them to some website and use URLs in the markdown file, if we do not want
to import any binary files.
> f. Search for SNAPSHOT references: find . -type f -name 'pom.xml' -exec
grep -l "SNAPSHOT" {} \;
> I found ./hadoop/pom.xml reference 0.8.1-SNAPSHOT.
Because hadoop module is not enable in v0.8.*, so it is not modified.
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Xiangdong Huang <[email protected]> 于2019年10月14日周一 下午5:32写道：
> And for this time, I have used `find apache-iotdb-0.8.1-incubating -name
> "*.jar"` to make sure that there is no jars in the source-release.zip file..
>
> Best,
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
> 黄向东
> 清华大学 软件学院
>
>
> Xiangdong Huang <[email protected]> 于2019年10月14日周一 下午5:30写道：
>
>> Hi all,
>>
>> I have fixed the issues in RC2. PPMC guys please have your vote.
>>
>> Best,
>> -----------------------------------
>> Xiangdong Huang
>> School of Software, Tsinghua University
>>
>> 黄向东
>> 清华大学 软件学院
>>
>
