Hi, Sure, and since your PR is currently not reporting any error, maybe I should fix this bug after your PR is merged so that it won't result in too many conflicts?
Best, ----------------------------------- Zesong Sun School of Software, Tsinghua University 孙泽嵩 清华大学 软件学院 > 2019年10月21日 22:14，Jack Tsai <[email protected]> 写道： > > Hi, > > First of all, thanks for your reply. > > I think adding param “String schemaPattern” might be unnecessary as the > function is querying all devices counting from “root” always (if my > understanding is correct). > > So far, I think we need to try working out an algorithm which could get all > the nodes in second to last level > > 取得 iOS 版 Outlook<https://aka.ms/o0ukef> > ________________________________ > 寄件者: 孙泽嵩 <[email protected]> > 寄件日期: Monday, October 21, 2019 1:59:57 PM > 收件者: [email protected] <[email protected]> > 主旨: Re: The issue about the interface of showing devices > > Hi, > > Sorry for the late reply. I’m responsible for this issue. > > In previous design, I ignore different length of path… Now that “device is at > the second to last level”, do you think it is necessary to add a new param > “String schemaPattern” for method “Set<String> getAllDevices()” as well? > Just like your modification for method “List<String> getNodesList(…)”. > > I’d like to keep focusing on your PR and help make effort to it. > > > Best, > ----------------------------------- > Zesong Sun > School of Software, Tsinghua University > > 孙泽嵩 > 清华大学 软件学院 > >> 2019年10月17日 09:20，Jack Tsai <[email protected]> 写道： >> >> Hi, >> >> As I was fixing the bug in the interface of querying timeseries, I found >> that there is also a problem in the past implementation of the interface >> which shows devices. >> >> Quoting from what Lei Rui told me: >> >> "Device is not necessarily at level 2. >> Device is at the secod to last level. >> For example, CREATE TIMESERIES root.demo.m2.m2.s0 WITH >> DATATYPE=INT32,ENCODING=RLE and the device should be root.demo.m2.m2." >> >> I think the original implementation of querying devices is incorrect, which >> only specified nodes from level 2 (the root node count as level 0). >> >> I would like to work on resolving this issue. If you have any advice, please >> welcome to tell me. >> >> Best regards, >> Jack Tsai >
