Hi Justin, Given that I wrote every line of that code, I'm allowed to stick whatever header I want on it. Please let me be clear: I'm only talking about the Java file.
Chris Am 19.11.19, 10:57 schrieb "Justin Mclean" <[email protected]>: Hi, Given the priject is not an ASF one why would it have an ASF header? Thanks, Justin On Tue, 19 Nov 2019, 19:52 Christofer Dutz, <[email protected]> wrote: > Hi Justin, > > this is a file I personally wrote and submitted to the maven-wrapper > project. > So technically it could have the Apache header ... after all, I put it > there. So I think the Apache header doesn't have to be replaced. > > Chris > > > > Am 18.11.19, 21:21 schrieb "Justin Mclean" <[email protected]>: > > HI, > > I’m -1 on this as the maven wrapper [1] is still not being handled > correctly, please read my previous comments. This is a 3rd party file and > should not have an ASF header, you can't alter the header of a 3rd party > file without permission. Thanks for fixing the other issues. > > Thanks, > Justin > > 1. .mvn/wrapper/MavenWrapperDownloader.java > > > >
