Hi, I have no other issues. look forward to rc4.
- signature and hash fine - DISCLAIMER exists - LICENSE and NOTICE ok for me - all ASF files have ASF source headers - can compile from source Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Kevin A. McGrail <[email protected]> 于2019年11月21日周四 上午10:07写道： > Any other issues that you see? That way we can streamline an rc4. > > On Wed, Nov 20, 2019, 21:05 Xiangdong Huang <[email protected]> wrote: > > > Hi, > > > > Sorry I want to -1.... > > > > "./tsfile/read_write_rle.tsfile" is not needed, it is generated by some > UT. > > This file is tooooo large, ~40MB, that is why I want to -1. > > > > Best, > > ----------------------------------- > > Xiangdong Huang > > School of Software, Tsinghua University > > > > 黄向东 > > 清华大学 软件学院 > > > > > > Justin Mclean <[email protected]> 于2019年11月21日周四 上午9:34写道： > > > > > Hi, > > > > > > +1 (binding) > > > > > > I checked: > > > - incubating in name > > > - signature and hash fine > > > - DISCLAIMER exists > > > - LICENSE and NOTICE good > > > - no unexpected binary files in course release, although there is this > > [1] > > > is this needed? > > > - all ASF files have ASF source headers > > > - can compile from source > > > > > > Thanks, > > > Justin > > > > > > 1. ./tsfile/read_write_rle.tsfile > > >
