HI all, I think the problem was that you were not doing the releases right or not staging the right artifacts. If you run release:perform ... it will checkout the git revision the prepare goal tagged as release version. It will checkout this into the target/checkout directory. There it will run a "mvn deploy" build without the maven-wrapper.
As it is doing this there simply can't be any class or jar file in the .mvn directory of the checkout directory. So then the assembly packs up everything in there, it simply can't pack up any class or jar files. The other problem you are having is that the build is generating things outside the target directory. That's a problem you definitely have to fix. As soon as that's done, there shouldn't be any problems as the target directories are automatically excluded. But in general the assembly would build the source bundle before actually running any tests and therefore there shouldn't be any binary resources. So I guess you re-ran the release build more than once ... So instead of fixing the symptoms, I would suggest to fix the cause. The cause is that you're not executing the release steps for Maven builds correctly. Chris But I definitely Am 01.12.19, 06:46 schrieb "Xiangdong Huang" <[email protected]>: Sorry the PR link is [1]. [1] https://github.com/apache/incubator-iotdb/pull/610 Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Xiangdong Huang <[email protected]> 于2019年12月1日周日 下午1:45写道： > Hi, > > Considering we packed some incorrect files in the last release (RC1 to > RC4), I think writing an assembly.xml file for generating the > source-release.zip is a good way to avoid that. > > What is more, it is very helpful when we switch different branches for > releasing. for example, in v0.9.0, there is a module called session, which > does not exist in 0.8.0. So, if I switch the branch from 0.9 to 0.8 (or > rel/0.8) for a minor version releasing (e.g., 0.8.2), I have to remove the > session folder manually. If I forgot that, a dirty source-release.zip is > generated. But if we have an assembly.xml, it will avoid that. > > I have written the source-assembly.xml now in PR [1]. The assembly file > looks ugly because we have to declare the files one by one. (I tried the > <moduleSet> tag, which is more convenient. But because our > module.artifactId != module.folder name, there is some issues that I can > not solve. Finally I gave up using <moduleSet> tag). > > If the PR is accepted, then for all contributors please notice that: > > (1) If you add new source files into a src/ docs/ license folder, it is ok. > (2) If you add a new module, create a new folder, or write a plain text > file under the project's (or a module's) root directory, you have to > maintain the source-assembly.xml file.. Otherwise the new added files will > not be packed into source-release.zip. > > Hope in this way, we can no longer get dirty source-release.zip files. > > [1] > Best, > ----------------------------------- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 >
