Hi,

+1 (binding) 

I checked:
- signatures and hashes file
- DISCLAIMER exists
- LICENSE and NOTICE fine
- No unexpected binary files
- All source files have ASF headers
- Can compile from source

In the license file you have "following class is modified from Maven Wrapper” 
twice.

I still don’t believe that file has the correct header and it should be updated 
to be this one [1]. It still unclear where exactly this file was copied from. 
Yes Chris created the original file, but there have been multiple changes by 
multiple people in that 3rd party repo and it’s unclear where this version has 
come from.

Saying:
"The following class is modified from Maven Wrapper, which is under Apache 
License 2.0:”
Doesn’t help as it’s unknown if that refers to [1] or somewhere else.

Thanks,
Justin

1. 
https://github.com/takari/maven-wrapper/blob/master/.mvn/wrapper/MavenWrapperDownloader.java

Reply via email to