Hi,

If you call the batch insertion of Data 1 as insertRows(),
why not call the batch insertion of Data 2 as  insertColumns()? or,
insertAlignedColumns();

> RowBatch -> SeriesBatch or ColumnBatch

I think the name is not clear. Is there better suggestion?

Data 1:
row1: time, device1, s1, s2
row2: time, device2, s3, s4

Data 2:
device1
time, s1, s2, s3
1       1     2    3
2       1     2    3
3       1     2    3

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Haonan Hou <[email protected]> 于2020年4月18日周六 下午1:39写道:

> Hi,
>
> +1. The new way of naming seems more straight forward.
>
> Thanks,
> Haonan
>
>
> > On Apr 18, 2020, at 1:29 PM, Jialin Qiao <[email protected]> wrote:
> >
> > Hi,
> >
> > The native API Session provides many methods. However, their names are
> > confusing. For example, insertBatch and insertInBatch.
> >
> > (1) insertBatch actually receives a RowBatch structure, which contains
> data
> > of multiple measurements of a device, these measurements data share the
> > same time column.
> >
> > If we treat it as a table, the table name is deviceId, the columns are
> > Timestamp, measurements name.  This table should not contain null value.
> >
> > For example
> > device1
> > time, s1, s2, s3
> > 1       1     2    3
> > 2       1     2    3
> > 3       1     2    3
> >
> > (2) insertInBatch insert multiple rows, each row contains a timestamp, a
> > deviceID and arbitrary measurements with values. Each row is independent.
> >
> > For example,
> > row1: time, device1, s1, s2
> > row2: time, device2, s3, s4
> >
> > So I plan to rename these methods.
> >
> > RowBatch -> SeriesBatch or ColumnBatch
> > insertBatch -> insertSeriesBatch or ColumnBatch
> > insertInBatch -> insertRows
> >
> > Does this look good to you?
> >
> > Thanks,
> > —————————————————
> > Jialin Qiao
> > School of Software, Tsinghua University
> >
> > 乔嘉林
> > 清华大学 软件学院
>
>

Reply via email to