Hi, And this reminds us that the iotdb-grafana module lacks UT/IT...
I notice Boris Zhu is working on a new Grafana plugin implementation (rather than using json-simple), Let's add more Tests in this implementation. Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Julian Feinauer <[email protected]> 于2020年5月1日周五 下午2:20写道： > Thanks both of you, I will later check it and then add a Docker file. Then > we can supply containers for this adapter which many people may like :) > > And start the release process ofc! > > Julian > > Holen Sie sich Outlook für Android<https://aka.ms/ghei36> > > ________________________________ > From: 孙泽嵩 <[email protected]> > Sent: Friday, May 1, 2020 5:29:09 AM > To: [email protected] <[email protected]> > Subject: Re: [Discuss] Release of 0.9.3 > > Hi Jialin, > > I was trying to find the cause of the exception haha … I’ve forgotten the > change of the grammar > Thanks a lot for your help !! > > > Best, > ----------------------------------- > Zesong Sun > School of Software, Tsinghua University > > 孙泽嵩 > 清华大学 软件学院 > > > 2020年5月1日 10:44，Jialin Qiao <[email protected]> 写道： > > > > Hi Julian, > > > > It's due to we change the grammar of group by query in 0.10. When cherry > pick to 0.9, the grammar is not changed correspondingly. > > I have fixed this bug in rel/0.9. Please have a check again. > > > > Thanks, > > -- > > Jialin Qiao > > School of Software, Tsinghua University > > > > 乔嘉林 > > 清华大学 软件学院 > > > >> -----原始邮件----- > >> 发件人: "Julian Feinauer" <[email protected]> > >> 发送时间: 2020-05-01 03:46:56 (星期五) > >> 收件人: "[email protected]" <[email protected]> > >> 抄送: > >> 主题: Re: [Discuss] Release of 0.9.3 > >> > >> Hey Zesong, > >> > >> thanks for the quick work. > >> I justed tested the bridge but I get exceptions now in Grafana. > >> Did you try to run it against Grafana? Or could anyone else check and > confirm that there is an issue (or probably its my setup?). > >> > >> Thanks! > >> Julian > >> > >> Am 30.04.20, 16:13 schrieb "孙泽嵩" <[email protected]>: > >> > >> Hi, Julian > >> > >> Thanks for your positive affirmation! > >> > >> I have tried to cherry-pick the commit and solved the conflict in > this PR [1], > >> and merge it to rel/0.9 after confirmation. > >> > >> > >> [1] https://github.com/apache/incubator-iotdb/pull/1138 < > https://github.com/apache/incubator-iotdb/pull/1138> > >> > >> > >> Best, > >> ----------------------------------- > >> Zesong Sun > >> School of Software, Tsinghua University > >> > >> 孙泽嵩 > >> 清华大学 软件学院 > >> > >>> 2020年4月30日 13:49，Julian Feinauer <[email protected]> 写道： > >>> > >>> Hi, > >>> > >>> thanks for your support. > >>> I already tried to pick the commit and it did not work (although I had > not too much time to check). > >>> > >>> So you can try it, and see if you get it fixed... alternatively I > could provide an implementation later today. > >>> > >>> Just let me know : ) > >>> > >>> Julian > >>> > >>> Am 30.04.20, 07:35 schrieb "孙泽嵩" <[email protected]>: > >>> > >>> Hi, > >>> > >>> I’ll try to cherry pick the related PR later… (but I’m not quite > familiar with cherry-pick operation… ) > >>> If there exists conflicts, maybe I could open a new PR based on > 0.9.2? > >>> What do you think? > >>> > >>> Best, > >>> ----------------------------------- > >>> Zesong Sun > >>> School of Software, Tsinghua University > >>> > >>> 孙泽嵩 > >>> 清华大学 软件学院 > >>> > >>>> 2020年4月30日 13:29，Xiangdong Huang <[email protected]> 写道： > >>>> > >>>> Hi Zesong, > >>>> > >>>> is that possible to cherry-pick the feature of > >>>> https://issues.apache.org/jira/browse/IOTDB-528 to 0.9.3? > >>>> > >>>> How much effort we need to do? > >>>> > >>>> Best, > >>>> ----------------------------------- > >>>> Xiangdong Huang > >>>> School of Software, Tsinghua University > >>>> > >>>> 黄向东 > >>>> 清华大学 软件学院 > >>>> > >>>> > >>>> Julian Feinauer <[email protected]> 于2020年4月29日周三 > 下午3:58写道： > >>>> > >>>>> HI, > >>>>> > >>>>> thanks for bringing that up as well. > >>>>> And I would also love to bring the "downsampling" feature ( > >>>>> https://issues.apache.org/jira/browse/IOTDB-528) to 0.9.3 as well > (ist > >>>>> already in 0.10). > >>>>> > >>>>> Julian > >>>>> > >>>>> Am 29.04.20, 09:43 schrieb "Xiangdong Huang" <[email protected]>: > >>>>> > >>>>> Hi, > >>>>> > >>>>>> If users execute a wrong DDL command, the restart of server will > >>>>> have no > >>>>> metadata, which is a critical bug. > >>>>> > >>>>> It is really a critical bug if the metadata is lost after the > server is > >>>>> restarted in some condition. > >>>>> > >>>>> +1 for release v0.9.3, > >>>>> as yesterday Julian and I fixed an issue that JDBC URL only > recognizes > >>>>> IP > >>>>> and rejects host domains... which also impacts user experience > deeply. > >>>>> > >>>>> Best, > >>>>> ----------------------------------- > >>>>> Xiangdong Huang > >>>>> School of Software, Tsinghua University > >>>>> > >>>>> 黄向东 > >>>>> 清华大学 软件学院 > >>>>> > >>>>> > >>>>> Jialin Qiao <[email protected]> 于2020年4月29日周三 下午3:20写道： > >>>>> > >>>>>> Hi, > >>>>>> > >>>>>> > >>>>>> Recently I find a bug. > >>>>>> > >>>>>> > >>>>>> If users execute a wrong DDL command, the restart of server will > >>>>> have no > >>>>>> metadata, which is a critical bug. > >>>>>> > >>>>>> > >>>>>> Therefore, we need to release 0.9.3. What do you think? > >>>>>> > >>>>>> Thanks, > >>>>>> -- > >>>>>> Jialin Qiao > >>>>>> School of Software, Tsinghua University > >>>>>> > >>>>>> 乔嘉林 > >>>>>> 清华大学 软件学院 > >>>>> > >>>>> > >>> > >>> > >> > >> > >
