Hi, +1,
I checked: 1. The source release: - incubating in name - apache headers - signatures and hashes - DISCLAIMER - LICENSE and NOTICE - no jar files - mvn package -DskipTests 2. The bin release: - start on MacOS, jdk11 - Grafana connector works Minor issue: - Grafana configuration file is not included. Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Jialin Qiao <[email protected]> 于2020年5月9日周六 下午3:01写道： > Hi, > > +1 > > The source release: > incubating in name [ok] > apache headers [ok] > signatures and hashes [ok] > DISCLAIMER [ok] > LICENSE and NOTICE [ok] > no jar files [ok] > could compile from source: ./mvnw.sh clean install [ok] > > The binary distribution: > signatures and hashes [ok] > start in mac, jdk8 [ok] > statements executed successfully: [ok] > > SET STORAGE GROUP TO root.turbine; > CREATE TIMESERIES root.turbine.d1.s0 WITH DATATYPE=DOUBLE, > ENCODING=GORILLA; > insert into root.turbine.d1(timestamp,s0) values(1,1); > insert into root.turbine.d1(timestamp,s0) values(2,2); > insert into root.turbine.d1(timestamp,s0) values(3,3); > select * from root; > > Thanks, > -- > Jialin Qiao > School of Software, Tsinghua University > > 乔嘉林 > 清华大学 软件学院 > > > -----原始邮件----- > > 发件人: "Christofer Dutz" <[email protected]> > > 发送时间: 2020-05-07 16:22:06 (星期四) > > 收件人: "[email protected]" <[email protected]> > > 抄送: > > 主题: Re: [VOTE] Apache IoTDB 0.9.3 (incubating) RC1 release > > > > +1 (binding) with minor issues > > > > Chris > > > > I checked: > > [OK] Download all staged artifacts under the url specified in the > release vote email into a directory we’ll now call download-dir. > > [OK] Verify the signature is correct > > [OK] Check if the signature references an Apache email address. > > [OK] Verify the SHA512 hashes: > > [OK] Unzip the archive (Rat did have some issues processing the ZIP > directly though) > > [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES > files in the extracted source bundle. > > [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files > in the extracted source bundle (See remarks following). > > [OK] Verify the staged source README, RELEASE_NOTE files correspond to > those in the extracted source bundle. > > [MINOR] Run RAT externally to ensure there are no surprises (Some files > are missing Apache headers). > > [OK] No unexpected binaries > > [OK] Search for SNAPSHOT references > > [OK] Build the project according to the information in the README.md > file. > > [OK] Build the project with all tests enabled and an empty maven local > repo: by appending -Dmaven.repo.local=../.m2. > > > > REMARKS: > > NOTICE: Not sure if the copyright notices of Hive and Commons have to be > updated to 2020 too. > > README.md: Would be nice to provide info on how to: "3. Set the max open > files num as 65535 to avoid "too many open files" problem." > > RAT: Couldn't run RAT on the source-archive directly ... got errors. > > Files missing license headers: > > > > test/apache-iotdb-0.9.3-incubating/server/src/assembly/resources/tools/logVisualize/plans/closeMetadataConsumption.plan > > > > test/apache-iotdb-0.9.3-incubating/server/src/assembly/resources/tools/logVisualize/plans/compressionRatio.plan > > > > test/apache-iotdb-0.9.3-incubating/server/src/assembly/resources/tools/logVisualize/plans/dynamicParameters.plan > > > > test/apache-iotdb-0.9.3-incubating/server/src/assembly/resources/tools/logVisualize/plans/flushSubmits.plan > > > > test/apache-iotdb-0.9.3-incubating/server/src/assembly/resources/tools/logVisualize/plans/memTableWait.plan > > > > test/apache-iotdb-0.9.3-incubating/server/src/assembly/resources/tools/logVisualize/plans/mergeFileNum.plan > > > > test/apache-iotdb-0.9.3-incubating/server/src/assembly/resources/tools/logVisualize/plans/mergeRate.plan > > > > test/apache-iotdb-0.9.3-incubating/server/src/assembly/resources/tools/logVisualize/plans/mergeSeriesProgress.plan > > However these seem to be simply config files, I would suggest to add > them as the format seems to support comments that's why I consider this a > Minor issues and not a blocker. If it had been code, I would have voted -1. > > > > > > Am 07.05.20, 08:00 schrieb "孙泽嵩" <[email protected]>: > > > > Hi all, > > > > Apache IoTDB (incubating) 0.9.3 is a bug-fix version from 0.9.2. You > can get its mainly changes from [5]. > > > > Apache IoTDB (Incubating) 0.9.3 has been staged under [2] and it’s > time to vote > > on accepting it for release. All Maven artifacts are available > under [1]. > > If approved we will seek final release approval from the IPMC. > > Voting will be open for 72hr. > > > > A minimum of 3 binding +1 votes and more binding +1 than binding -1 > > are required to pass. > > > > Release tag: release/0.9.3 > > Hash for the release tag: a704aa2cd6a61db57c5495f8b43849be876a1980 > > > > Per [3] "Before voting +1 [P]PMC members are required to download > > the signed source code package, compile it as provided, and test > > the resulting executable on their own platform, along with also > > verifying that the package meets the requirements of the ASF policy > > on releases.” > > > > You can achieve the above by following [4]. > > [ ] +1 accept (indicate what you validated - e.g. performed the > non-RM items in [4]) > > [ ] -1 reject (explanation required) > > > > > > [1] > https://repository.apache.org/content/repositories/orgapacheiotdb-1034 > > [2] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.9.3/rc1 > > [3] https://www.apache.org/dev/release.html#approving-a-release > > [4] > https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release > > [5] > https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.9.3/rc1/RELEASE_NOTES.md > > > > > > Best, > > ----------------------------------- > > Zesong Sun > > School of Software, Tsinghua University > > > > 孙泽嵩 > > 清华大学 软件学院 > > > > >
