Hey Xushenh Zhang,

If you want i have a task for you, then during the next weekend we will fix thrift together. In the current implementation there are two things that have no dependencies and we can port soon since we will need it soon:

1. Bloomfilters.

2. MurmurHash.

Both are in the /src/main/java/org/apache/iotdb/tsfile/utils directory. We dont want and like MurmurHash, it is broken by DJB using differential analysis and

since we want high quality code (we as programmers are paid to produce less code possible), we suggest to use highwayhash or siphash.  So the idea is :

1. Port bloomfilters from java to c++

2. In the port using https://github.com/google/highwayhash/, integrating highwayhash in our CMake.

The only reason of existence in the java code of Murmurhash is the bloomfilter implementation.

The task is very simple. It would take 4/6 hours at most.

Let me know if you want otherwise i will do it tomorrow.

Best Regards,

Giorgio



Reply via email to