+0. In some ways, I agree with Chao Wang. Generally, we just need squash, sometimes we may need to merge directly (if and only if all commit logs are meaningful)
But on the other hand, PR should not be too large to have many commits logs. Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 王超 <[email protected]> 于2021年1月4日周一 下午7:43写道： > Hi， all > > > -1, I think if a big feature has several commits is ok and meaningful, I > think change the default merge to squash merge is more suitable. > > > Thanks. > > > Chao Wang > > > BONC, Ltd > [email protected] > On 1/4/2021 17:58，Houliang Qi<[email protected]> wrote： > Hi, all > > > Big +1 > > > Thanks, > --------------------------------------- > Houliang Qi > BONC, Ltd > > > On 01/4/2021 12:41，Xinyu Tan<[email protected]> wrote： > Hi,all > > In current status, IoTDB repository is accepting `Allow merge commits` in > merging pr, which causes a lot useless commits. > > In order to make the project code management process more formal, I would > like to ask a vote to discuss whether we need to disable the other merge > method and only allow squash-merge when merging pr. > > If everyone supports it, then we can refer to other projects[1][2][3] and > notify infra. > > My vote is +1. > > [1] > > https://issues.apache.org/jira/browse/INFRA-16146?jql=text%20~%20%22squash%20merge%22 > [2] > > https://issues.apache.org/jira/browse/INFRA-16669?jql=text%20~%20%22squash%20merge%22 > [3] > > https://issues.apache.org/jira/browse/INFRA-17098?jql=text%20~%20%22squash%20merge%22 > > Best > ---------------------- > Xinyu Tan >
