Thanks for bring up this discussion, Xiangdong! The problem of network access is really a long-term problem for Chinese users. For the convenience of users, we really need a special warehouse to store the current and future pictures and binary files.
So, +1 for creating the `apache/iotdb-resources` to store all these files for both `iotdb` and `iotdb-website` repo. Best, Jincheng Xiangdong Huang <saint...@gmail.com> 于2021年2月15日周一 上午9:02写道： > Hi Chris, > > 1. About thrift. > Indeed we learned from PLC4x and maintain a module to compile thrift (as > well as boost initially, but it still requires installing flex and bison. > and finally we give up compiling boost, and only maintain compiling > thrift). But now it is just used to generate static or dynamic library for > c++ codes. > > The question is, users who want to compile the source code has to install > flex, bison, and boost (byw, flex and bison have version requirements) > first... It is not very friendly (and time consuming) for new users. > > 2. For images > In our docs (in markdown files), we use external links (e.g., [1], provided > by github). They are not accessible in China. > > A simple solution is saving the original image files to our repo (e.g., > create a folder called 'imgs'), and use relative path in our markdowns. > After compiling the website, the generated static htmls will keep using the > relative path and thereby they will be accessible in China (as they will be > upload to iotdb.apache.org). > > But the drawback is it will increase the size of the repo (images are > binary files so that once we update an image, the whole file will be > replaced, and the git history has few meaning). That is why I'd like to > create a new repo and users/developers can choose whether they need to > clone the repo. > > > [1] > > https://user-images.githubusercontent.com/19167280/73625222-ddd88680-467e-11ea-9098-e808ed4979c5.png > > Best, > ----------------------------------- > Xiangdong Huang > School of Software, Tsinghua University > > 黄向东 > 清华大学 软件学院 > > > Christofer Dutz <christofer.d...@c-ware.de> 于2021年2月14日周日 下午11:14写道： > > > Hi Xiangdong, > > > > regarding thrift ... how about doing it similar to our Maven-triggered > > Thrift build in PLC4X? > > I'm admittedly not a fan of requiring stuff in Apache projects which is > > maintained by individuals. > > > > It doesn't have to be built every time but it would be great if there was > > a job we could manually trigger to build the Thrift compiler executalbes > > every time we need them. > > > > But regarding images: ... where are these referenced? Why not put the > > image resources in the repo where also the content is located? Perhaps > > however I'm not understanding the setup correctly though. > > > > > > Chris > > > > > > -----Ursprüngliche Nachricht----- > > Von: Xiangdong Huang <saint...@gmail.com> > > Gesendet: Sonntag, 14. Februar 2021 15:08 > > An: dev <dev@iotdb.apache.org> > > Betreff: [DISCUSS] Create a new Repo to upload binary files (images for > > markdown, compiled thrift binary, etc..) > > > > Hi, > > > > Currently, we upload all figures to github's issues to get a public URL > > and use it in our markdown files. The question is, it is hard to maintain > > the figures, and, the URL is *.githubusercontent.com/*, which maybe can > > not be accessed in China. > > > > Besides, we are using compiled thrift binary from > > https://github.com/jt2594838/mvn-thrift-compiler/. Though it is compiled > > by our committer Tian Jiang, it is a personal repo and may get suspected > by > > users. > > > > Therefore, I'd like to apply for creating a new repo, > > apache/iotdb-resources to collect all these files. > > > > The repo can be as a git submodule of iotdb, and so that all figures can > > be used as a relative path in markdowns. As a result, the figures will be > > compiled as local files for our website (i.e., all figures' URL are > > iotdb.apache.org/* rather than githubusercontent.com/*). > > > > thrift compiler will also be download from apache/iotdb-resources, which > > will convincing users and is more controllable. > > > > Why not upload these resources directly to apache/iotdb: for controlling > > the size of iotdb's repo. > > > > Best, > > ----------------------------------- > > Xiangdong Huang > > School of Software, Tsinghua University > > > > 黄向东 > > 清华大学 软件学院 > > >
