Hi,

+1 (binding)

I checked these on my Mac, JDK 8 and 11

The source release:
LICENSE and NOTICE [ok]
signatures and hashes [ok]
could compile from source: mvn clean install [not ok] 
some generated py files should be ignored by rat checker

The binary distribution:
signatures and hashes [ok]
start server and CLI in mac, jdk8 and jdk11 [ok]
Could run with the following statements [ok]

SET STORAGE GROUP TO root.turbine;
CREATE TIMESERIES root.turbine.d1.s0 WITH DATATYPE=DOUBLE, ENCODING=GORILLA;
insert into root.turbine.d1(timestamp,s0) values(1,1);
insert into root.turbine.d1(timestamp,s0) values(2,2);
insert into root.turbine.d1(timestamp,s0) values(3,3);
select * from root;

Best,

Haonan Hou

> On Mar 5, 2022, at 3:05 PM, Jialin Qiao <[email protected]> wrote:
> 
> Hi,
> 
> +1 (binding)
> 
> The source release:
> apache headers [ok]
> signatures and hashes [ok]
> LICENSE and NOTICE [ok]
> no jar files [ok]
> could compile from source: ./mvnw.sh clean install [ok with minor issue]
> 
> minor issue:
> 
> [*WARNING*] Files with unapproved licenses:
> /Users/qiaojialin/Desktop/apache-iotdb-0.12
> .4/client-py/iotdb/thrift/__init__.py
> /Users/qiaojialin/Desktop/apache-iotdb-0.12
> .4/client-py/iotdb/thrift/rpc/__init__.py
> 
> These two files are generated when compiling the source code, we should
> omit them.
> 
> 
> The binary distribution:
> version number in CLI [ok]
> signatures and hashes [ok]
> start in mac, jdk8 [ok]
> statements executed successfully:  [ok]
> 
> SET STORAGE GROUP TO root.turbine;
> CREATE TIMESERIES root.turbine.d1.s0 WITH DATATYPE=DOUBLE, ENCODING=GORILLA;
> insert into root.turbine.d1(timestamp,s0) values(1,1);
> insert into root.turbine.d1(timestamp,s0) values(2,2);
> insert into root.turbine.d1(timestamp,s0) values(3,3);
> select * from root;
> 
> Thanks,
> —————————————————
> Jialin Qiao
> School of Software, Tsinghua University
> 
> 乔嘉林
> 清华大学 软件学院
> 
> 
> Steve Yurong Su <[email protected]> 于2022年3月4日周五 20:47写道:
> 
>> Hi all,
>> 
>> Apache IoTDB 0.12.5 is a bug-fix version from 0.12.4. You can get its
>> main changes from [1]. Apache IoTDB 0.12.5 has been staged under [2]
>> and it’s time to vote on accepting it for release. All Maven artifacts
>> are available under [3].
>> 
>> Release tag: v0.12.5
>> Hash for the release tag: 03f276e086c5c6ef2d9d3de9e01c2bada5fa0b6e
>> 
>> Voting will be open for 72hr. A minimum of 3 binding +1 votes and more
>> binding +1 than binding -1 are required to pass.
>> 
>> Before voting +1, PMC members are required to download the signed
>> source code package, compile it as provided, and test the resulting
>> executable on their own platform, along with also verifying that the
>> package meets the requirements of the ASF policy on releases[4].  You
>> can achieve the above by following [5].
>> 
>> [ ]  +1 accept (indicate what you validated - e.g. performed the
>> non-RM items in [5])
>> [ ]  -1 reject (explanation required)
>> 
>> ------
>> [1]
>> https://dist.apache.org/repos/dist/dev/iotdb/0.12.5/rc1/RELEASE_NOTES.md
>> [2] https://dist.apache.org/repos/dist/dev/iotdb/0.12.5/rc1
>> [3]
>> https://repository.apache.org/content/repositories/orgapacheiotdb-1075/
>> [4] https://www.apache.org/dev/release.html#approving-a-release
>> [5]
>> https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release
>> [6] https://dist.apache.org/repos/dist/dev/iotdb/KEYS
>> ------
>> 
>> Thanks,
>> Steve Yurong Su
>> 
> 

Reply via email to