Hi, Here are some could be renamed:
server module -> datanode module iotdb-engine.properties -> iotdb-datanode.properties start-new-server.sh -> start-standalone.sh stop-new-server.sh -> stop-standalone.sh Thanks, ————————————————— Jialin Qiao Apache IoTDB PMC Yuan Tian <[email protected]> 于2022年6月26日周日 09:56写道： > Hi, > > Capitalizing MPP may be better. > > On Sat, Jun 25, 2022 at 11:58 PM Jialin Qiao <[email protected]> > wrote: > > > > Hi, > > > > I'm renaming the DataBlockManager related, please leave this for me > > > > dataBlockManagerEndPoint -> mppDataExchangeEndPoint > > > > Thanks, > > ————————————————— > > Jialin Qiao > > Apache IoTDB PMC > > > > > > Xiangdong Huang <[email protected]> 于2022年6月25日周六 23:19写道： > > > > > Hi, > > > > > > When reading the source codes on the master branch, > > > I noticed that some classes and fields names can be renamed for better > > > understanding. > > > > > > Better to rename these names before releasing because > > > I am not sure whether the generated thrift codes are compatible if we > > > modify them later. > > > > > > e.g., > > > > > > common.thrift: > > > - TRegionLocation to TRegionInfo > > > (seems this is not a "location", though I do not know the defination > > > of "location") > > > > > > - TConfigNodeLocation: > > > * internalEndPoint -> rpcEndPoint > > > > > > - TDataNodeLocation: > > > * externalEndPoint -> clientRpcEndPoint > > > * internalEndPoint -> configNodeRpcEndPoint > > > * dataBlockManagerEndPoint -> dataNodeRpcEndPoint > > > > > > Best, > > > ----------------------------------- > > > Xiangdong Huang > > > School of Software, Tsinghua University > > > >
