Ok .. and now I know why we’re at 0.14.1. Turns out 0.17.0 has an issue in its MANIFEST.mf which causes our build to fail. According to Maven-Central do all older versions till 0.14.1 have known vulnerabilities, so we shouldn’t choose any of those. Turns out that 0.14.1 is the sweet spot where we support Java 8, are able to build and don’t inherit any CVEs.
Perhaps we should discuss dropping Java 8 support. Chris Von: Christofer Dutz <christofer.d...@c-ware.de> Datum: Montag, 31. Juli 2023 um 16:06 An: dev@iotdb.apache.org <dev@iotdb.apache.org> Betreff: AW: [DISCUSS] Updating to a newer Thrift version? So, inspecting all versions between 0.14.1 and 0.18.1 it turns out 0.17.0 was the last one able to be used in Java 8 applications. I therefore updated my branch to that version. Chris Von: Christofer Dutz <christofer.d...@c-ware.de> Datum: Montag, 31. Juli 2023 um 15:53 An: dev@iotdb.apache.org <dev@iotdb.apache.org> Betreff: AW: [DISCUSS] Updating to a newer Thrift version? Hi all, well … cancel that … it seems that Thrift 0.18.1 is compiled with newer java versions and we can no longer, consume the jar in the Java 8 build. Chris Von: Christofer Dutz <christofer.d...@c-ware.de> Datum: Montag, 31. Juli 2023 um 15:50 An: dev@iotdb.apache.org <dev@iotdb.apache.org> Betreff: AW: [DISCUSS] Updating to a newer Thrift version? Aaaah … ok That’s an explanation … I did try the build in my branch with 0.18.1 and it worked nicely. Chris Von: Yuan Tian <jackietie...@gmail.com> Datum: Montag, 31. Juli 2023 um 14:45 An: dev@iotdb.apache.org <dev@iotdb.apache.org> Betreff: Re: [DISCUSS] Updating to a newer Thrift version? Hi Chris, I remember that we tried to upgrade to 0.15.X before, but the performance declined. I'm not sure about that? Anyone else remember? Best, --------------- Yuan Tian
