+1 for the vote. Haonan
On 2023/08/17 15:47:17 Christofer Dutz wrote: > Ok, > > it turns out that the windows artifacts were „Debug” versions … had to > re-stage the artifacts: > https://repository.apache.org/content/repositories/orgapacheiotdb-1129/ > > Chris > > > Von: Christofer Dutz <[email protected]> > Datum: Donnerstag, 17. August 2023 um 15:46 > An: [email protected] <[email protected]> > Betreff: AW: Deploying the iotdb-tools-thrift artifacts ... > Giving the artifacts a spin in a PR: > https://github.com/apache/iotdb/pull/10893 > > Chris > > Von: Christofer Dutz <[email protected]> > Datum: Donnerstag, 17. August 2023 um 15:29 > An: [email protected] <[email protected]> > Betreff: AW: Deploying the iotdb-tools-thrift artifacts ... > Hi all, > > So, I finished copying the iotdb-tools-thrift to the other repo and set it up > to work independently from the rest of our build. > https://github.com/apache/iotdb-bin-resources/tree/main/iotdb-tools-thrift > > This produces the thrift module under a slightly different groupId: > > <dependency> > <groupId>org.apache.iotdb.tools</groupId> > <artifactId>iotdb-tools-thrift</artifactId> > <version>0.14.1.0</version> > </dependency> > > The different groupId indicates that it’s not part of the main repo. > > And I was a bit torn about the version number: > > * 1.3.0-SNAPSHOT (Was sub ideal, as the artifact generally has no > relation to IoTDB, but more to Thrift) > * 1.14.1 (Also felt sub-ideal, as we couldn’t update the configuration, > if we needed to re-deploy without changing the Thrift version) > * 1.3.0-SNAPSHOT-1.14.1 (Felt even worse, as it’s so long and we would > actually need to re-release everything before every IoTDB version) > * 1.14.1.0 (Was what I chose … it shows the relation to Thrift and it > allows us to re-deploy updated versions of the binary artifacts) > > Also did I take the library of testing staging of release artifacts. > https://repository.apache.org/content/repositories/orgapacheiotdb-1128/ > > Currently the deployment process still feels a bit rough … I’ve documented > it, but I guess I’ll be able to soften the edges over time. > > If you folks agree, I’d be for starting a vote on releasing the RC that I > staged in above repo. > > Then we should no longer have any problems with deleted thrift binaries and > we should be able to build on all platforms without any complicated setup. > > Chris > > > > > Von: Haonan Hou <[email protected]> > Datum: Donnerstag, 17. August 2023 um 09:25 > An: [email protected] <[email protected]> > Betreff: Re: Deploying the iotdb-tools-thrift artifacts ... > Good, looking forward your update about it. :) > > Best, > Haonan > > On 2023/08/17 07:08:39 Christofer Dutz wrote: > > Yeah we sort of do... But the content of the artifact is going to contain > > two xml files. But it's going to simplify things a lot. > > > > Chris > > > > Gesendet von Outlook für Android<https://aka.ms/AAb9ysg> > > ________________________________ > > From: Haonan Hou <[email protected]> > > Sent: Thursday, August 17, 2023 3:54:43 AM > > To: [email protected] <[email protected]> > > Subject: Re: Deploying the iotdb-tools-thrift artifacts ... > > > > I have one more question. If we are going to release the iotdb-tools-thift > > library, do we need to a vote for it? > > > > Haonan > > > > On 2023/08/16 12:19:44 Christofer Dutz wrote: > > > Hi all, > > > > > > > > > Today I was made aware that there were issues with the thrift compiler > > > artifacts that I switched to using in my last refactoring. > > > > > > When having a look in Nexus I could see that the libraries staged there > > > weren’t the ones I put there as they had a different structure, were no > > > longer containing statically linked thrift executables, didn’t have > > > libraries and includes in them. So someone must have deployed them but > > > must have used an old state of the master branch. > > > > > > But we solved the problem, why they keep on disappearing :-/ > > > > > > When deploying all 5 artifacts, we run a maven build 5 times and deploy 5 > > > snapshots of the same artifact. On Saturday a cleanup job removes all but > > > the newest 3 snapshots of each artifact. > > > > > > So if we want to keep on using the SNAPSHOT versions, we will have to > > > re-reploy them every Saturday. > > > > > > I would however encourage us to do something different: > > > > > > Move the “tools” part into the > > > https://github.com/apache/iotdb-bin-resources repo and release the > > > iotdb-tools-thift library (I’d recommend simply using the thrift version > > > instead of the iotdb version as the library actually has absolutely > > > nothing to do with iotdb and is just a compilation of thrift packaged in > > > a way that we can use it. > > > Then this problem would be gone forever and we’d only need to re-do it if > > > we switch to a new Thrift version. > > > > > > What do you think? > > > > > > Chris > > > > > > > > >
