Thinking about it a bit more … I think we should remove this plugin and the code that uses it. The reasoning behind this is that I will break build reproducibility.
In theory someone should be able to download the source bundle from Apache servers, verify the hashes and the signatures and then be able to build binary identical jar files. This plugin or the file that it generates will break this ability. Chris Von: Christofer Dutz <christofer.d...@c-ware.de> Datum: Donnerstag, 18. April 2024 um 14:40 An: dev@iotdb.apache.org <dev@iotdb.apache.org> Betreff: AW: Potential problem with the git-commit-id-plugin in node-commons Hi all, digging a bit deeper I found that it would not cause problems in case of a source bundle, as there is this setting: <failOnNoGitDirectory>false</failOnNoGitDirectory> I assume that the worktree support does some strange things that this plugin doesn’t operate with correctly. So I added this setting: <failOnUnableToExtractRepoInfo>false</failOnUnableToExtractRepoInfo> And that solved the issue for me. Chris Von: Christofer Dutz <christofer.d...@c-ware.de> Datum: Donnerstag, 18. April 2024 um 14:32 An: dev@iotdb.apache.org <dev@iotdb.apache.org> Betreff: Potential problem with the git-commit-id-plugin in node-commons Hi all, I was playing around with the new IntelliJ Worktree support (Checking out multiple versions of the same project) and got a failure in node-commons. Having a deeper look at it, it seems that the build requires iotdb to be a git repository. While this is true for regularly checked-out code, it would not work when building IoTDB from a source bundle downloaded from Apache. I think we shouldn’t require such a plugin in our build. What is it used for anyway? Chris
