Hi, I have attempted to update the version of Spotless and have passed integration testing on Java 8, Java 11, and Java 17. If there are no other issues with PR integration, it may be necessary to avoid using Java 8 for development as much as possible. At the very least, before submitting the code, ensure that the MVN Spotless: check runs successfully through Java 11 or above versions, otherwise CI will run incorrectly.
https://github.com/apache/iotdb/actions/runs/8699628709/job/23858547750?pr=12345 发件人: Christofer Dutz <[email protected]> 日期: 星期二, 2024年4月16日 15:28 收件人: [email protected] <[email protected]> 主题: AW: Totally outdated Spottless version? Hi, well, I guess there’s a difference between which JDK is being used or which language-level we’re compiling for. Different surveys, different outcome: https://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fnewrelic.com%2Fresources%2Freport%2F2023-state-of-the-java-ecosystem%23most-used-java-versions&data=05%7C02%7C%7C12ce914371cc408824c508dc5de6cf4d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638488493171558670%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=ulJVTGSaluoiPvrJ07%2BDHZR8%2BTchj1NRSt7pHfkpB10%3D&reserved=0<https://newrelic.com/resources/report/2023-state-of-the-java-ecosystem#most-used-java-versions> In PLC4X we have some dependency checks, that check that dependencies are class-format compatible with our desired base-line JDK version (11). In order to be able to not be stuck with too old build tools, we decided early to have a higher base-line version for building PLC4X than for running applications. I think till the beginning of this year we had the build require Java 11 and the runtime to be 8. In order to ensure the output worked, we had some tools in pace to ensure that. Chris Von: Wang Critas <[email protected]> Datum: Dienstag, 16. April 2024 um 05:16 An: [email protected] <[email protected]> Betreff: 答复: Totally outdated Spottless version? According to the latest report, Java 8 still has the highest developer share, although the 17+11 share is not significantly different. But what we need to ensure for the upgrade is that all code can still be compiled and run in Java 8, or consider updating it on Apache/tsfile first https://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.jetbrains.com%2Flp%2Fdevecosystem-2023%2Fjava%2F&data=05%7C02%7C%7C12ce914371cc408824c508dc5de6cf4d%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638488493171568020%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=rauPl6V7bR1aClHkaOQ7SPW37ViVT7RhSNC7ViH9UG0%3D&reserved=0<https://www.jetbrains.com/lp/devecosystem-2023/java/> 50% Java 8 45% Java 17 38% Java 11 11% Java 20 8% Java 18 8% Java 19 3% Java 16 2% Java 14 2% Java 12 2% Java 7 2% Java 15 1% Java 13 发件人: Christofer Dutz <[email protected]> 日期: 星期一, 2024年4月15日 15:54 收件人: [email protected] <[email protected]> 主题: Totally outdated Spottless version? Hi all, while going through the plugins in the new split-up repository, I came across the profile, that disabled spotless on Java 21 and above. It seems this issue was fixed quite some time ago and simply updating to an a lot more recent version of spotless should resolve the issue. I think the reason we stuck to the ancient version that we did, was as this was the last version able to build with Java 8. I would propose to turn the logic, to exclude the spotless check for java versions older than the supported java version and to enable spotless on all newer versions. Chris
