Well, In that case I would -1 that proposal.
If it was a clean separation of concerns, then I would +1 that. The reason is that technical debt is so easily accumulated. Even if the intentions to clean up things later is always present, in reality it rarely happens. So if this is so important for you, then please add a little more effort to do a clean separation. One thing I regularly complained about and kept on bringing up, is that our test suite, thanks to the excessive usage of Singletons, is not able to run multiple tests in parallel safely within the same VM anyway. Usually the easy path is always a path to a darker future. Chris Von: Yuan Tian <[email protected]> Datum: Mittwoch, 11. Februar 2026 um 08:07 An: [email protected] <[email protected]> Betreff: Re: PROPOSAL: move freemarker to a separate module Hi Christofer, Thanks for your perspective. To clarify, the current proposal is solely aimed at enabling multi-threaded compilation for the DataNode module to improve build speed. At this stage, there is no deeper logical or functional separation intended. Best, Yuan On Wed, Feb 11, 2026 at 3:02 PM Christofer Dutz <[email protected]> wrote: > If this is also a logical split, then I'm all for it. If it's a plugin > based split I would ask for a different cut. We already have the antlr > module, which actually is a sql parser (I think). > > So the cut out module should not just contain the drill_generated classes, > but be a functional unit. > > Chris > > Gesendet von Outlook für Android<https://aka.ms/AAb9ysg> > ________________________________ > From: Yuan Tian <[email protected]> > Sent: Wednesday, February 11, 2026 5:25:43 AM > To: [email protected] <[email protected]> > Subject: Re: PROPOSAL: move freemarker to a separate module > > Yes, I think so. > > On Tue, Feb 10, 2026 at 10:28 PM Christofer Dutz < > [email protected]> > wrote: > > > You’re referring to the drill plugin thing, right? > > > > Chris > > > > > > Von: Yuan Tian <[email protected]> > > Datum: Dienstag, 10. Februar 2026 um 13:28 > > An: [email protected] <[email protected]> > > Betreff: Re: PROPOSAL: move freemarker to a separate module > > > > Hi Tian, > > > > This is a great proposal. Moving Freemarker to a separate module to > enable > > parallel compilation for DataNode is a valuable idea. I fully support > this > > change. When can we expect this work to start? > > > > Best, > > Yuan > > >
